IssueTracker

yes the compatibility is a must have.

must have.

Must have

woah thanks for the fix! this is very helpful

must have+1

Awesome! how do i install it though?

Right how to install?

You need root to install it at the moment.
1. Download the file from the first post
2. Copy the file to /system/usr/keylayout
3. set the permisions of the file to 644

And make sure the controller's firmware is updated.

This is awesome! TY!
Now I just wish that someone would add support for the Gamecube WII USB Adapter. That would be amazing!  Any chance you could look into it? I guess it's working on Linux... so if you're techy, you should be able to convert it over pretty easily.

Thanks for this, works great!

Works great but have to reroot and reinstall the keymap after each android update... Please include this keymap for next version of Android / Android TV. Thanks.

It seems like someone made a patch that needs to be approved first.
https://android-review.googlesource.com/#/c/284883/

[Comment deleted]

This worked on my Shield K1 Tablet great. Thanks!

Any chance we can get a keylayout for the 02e6 (Xbox Wireless Adapter)? I can't seem to find it anywhere.

With the latest controller update from MS these controllers work with stock setup. If you don't have an Xbox one, you need to download the xbox accessories app from the windows 10 store to update the firmware on the controller.

Anyone else having issue with the controllers not working after the system reboots? I find myself constantly having to repair the controllers to make them work.

A forum on NeoGAF found this issue is caused by steam. The controller would stop working after it goes to sleep the first time after computer reboot. I was able to get the controller working again by restarting steam.

I can't pair mine with my Xperia Z5 (says wrong pin number) does anyone have the same problem ?

[Comment deleted]

God Sent!

Edit: Just updated the Xbox One (Bluetooth) controller's firmware today (Jan 4th 2017) and now the mapping of the buttons are all messed up again... ARGH!!

Do we need a new keylayout file or is there a way to reconfigure the file in the OP?

It seems like Microsoft changed the layout with the new update. I will look into it in the next few days.

Thank you so much! I also noticed that the update changed my remote Device ID from 02e0 to 02ea. By renaming your file to match the new Device ID made it a lot better however I noticed it's no longer optimized. It works most of the time but periodically something will trigger one of the buttons out of the blue. For example in Order and Chaos, when you run with the left joystick for like 5 seconds, all of a sudden character menu opens, or midway through combat your inventory pops up.
Same thing happens in Space Marshal 2 and Fallout 4 (Stream via Moonlight)

Looking forward to you working your magic :)

Talking about Device ID... My XBox One S bluetooth controller's ID (before last update) seems to be 02fd, and not 02e0. Am I the only one?

it seems the key mapping is no more needed,
Microsoft fixed the mapping with a internal firmware update.
if you added the key mapping you have to remove it.
but now the new bug is
on some device when pairing it ask a password.
but it affect only some devices.

I have the same 02fd ID and I didn't got a Jan 4th update, I updated it on Dec, 31 with the firmware 3.1.1221.0. The Xbox Accesories app doesn't show a new update from the one I currently have. I didn't rooted my device (yet), in order to put the Vendor_045e_Product_02e0.kl mapping, but this would definitely not do anything since I have 02fd product and not 02e0. Also the controller connected to a Fire Tablet, without any custom mappings, has the controls mapped wrong.

I suggest we reference all data in a sheet. I started.

https://docs.google.com/spreadsheets/d/1BXAxNLbt9N344yd1EPZWGzkXboSD65B-4Zri703t-vY/edit?usp=sharing

Andi,
Rename the custom file in the original post to match your device id and it'll work.
Or alternatively try to update your controller via someone else Xbox or PC and see if that works.

Tails,
It appears that deleting custom key layouts fix most of the issue so far.  Hopefully it stays that way with future updates as well

I'm on latest pad firmware (December one, previous versions paired more or less succesfully) and on CM13, this pad now doesn't pair at all, saying "wrong PIN". Is there a possibility to edit this PIN in config files? Also I checked this on I9300 (Galaxy S3) with CM14 (Resurrection Remix, early December version) - the same error.

Max, try this:
Find out what your remote's Device ID is (google this. Can be done on PC by going to driver's properties)
Then rename the file above to match your device ID. That should bypass the PIN bug and connect but your key mapping will be all weird. Then once you "Smart Connect and save it as trusted device" then delete the key layout file mentioned earlier. Now your device should connect to the remote without asking for PIN.
I'm not sure if this workaround works everytime or not.

[Comment deleted]

Thank you, Kevin, I wonder though if key definition file bypasses the PIN requirement? Is there any possibility to edit default PIN having root privileges?
I have 02e0 ID, it seems, at least in W10 as BT device :)

Hey Max,
I'm not sure if that actually bypass the PIN or if it just trick the device into thinking it's an older firmware that didn't require PIN. I read online that some had success in using that method while others didn't. Being rooted I'm sure you can find an API editor or some type of App that bypass the PIN via entering the MAC address manually. I'll look on my days off but as of right now I'm stumped as well. Thankfully it works flawlessly on both my S6 Edge and Tab S2, but not on my son's Tab 2 :(

Unfortunately, this method doesn't work for me here ^_^
Thank you for your time with pinpointing this problem, I'll also try to look further :)

For now,there's simply no way do to that - Microsoft crippled the device with December firmware update. Dick move, MS. In addition there's no way to downgrade for now.

got this issue,, the newest xb1 controller firmware only work on old mid-end device(lg g3 stylus, nexus7-2012) and not work with high-end device, I think this is caused by bluetooth version 4.0, 4.1.

Hey can it work on mcpe? Microsoft added a key mapping of controller there

worked like a charm, I'm not on never firmware, and at this point I see no need  to do so.

I am going to do a bit of a writeup.

I have a OnePlus 5 on Android 7.1.2 and I bought an Xbox One Bluetooth (black/military green monocolor with orange underneath thumbsticks, Lot No/Date 1647 (indicating built in year 2016) with Model No 1708 and WL3-00035. I was trying to play Geometry Wars 3 with the Xbox One controller out of the box and the left stick worked great, however the right stick was not functioning as expected. After a couple hours of research, I stumbled upon this thread and tested out the keyboard input files by placing them into /system/usr/keylayout with permissions 644, and the right stick started working properly and the start button which used to be the middle Xbox button was now the start button as expected. All was good. I updated the firmware of my Xbox One controller using the Xbox Accessories app with a Micro USB cable on my Windows 10 laptop and then tested out the controller again on my OnePlus 5 - the start button is now the right bumper (RB) button, but both sticks and A and B are still working fine. I would suggest not updating, unless someone can somehow update the mapping files. However, I tested the latest Xbox One controller firmware with and without the mapping files and without it, the right stick would not work again indicating that the mapping files are still working.

My OnePlus 5 has Bluetooth 5.0 but I can also try out my Nexus 6P which has Bluetooth 4.2 to see how well the Xbox One controller works both with and without the mapping files on the latest Xbox One controller firmware. I suspect it will work about the same as my OnePlus 5.


All in all, this is awesome, thank you so much, OP! <3

Sorry for double posting but it seems that the Google issue tracker does not allow editing of comments - that's a shame. After disconnecting and reconnecting my Xbox One controller again to my OnePlus 5 with the latest Xbox One controller firmware, it seems like all the buttons are working again as expected - start is the start button, RB is what it is supposed to be, X is working again, etc. It seems that updating the firmware didn't seem to affect the mapping files for me whatsoever - all is working fine for me. Just thought I would inform people of my experiences with this and the latest (presumably December, although I am unsure how to check) Xbox One controller firmware. :)

The keys are all corresponding, but LT and RT still cannot be used. Is there a solution?

I'm having the same issue. Trigger buttons are not working or rather are not mapped correctly.

When I boot up Gamepad Tester and fiddle around with the controller, all the buttons are correctly mapped except for LT and RT which are mapped to the BRAKE axis (assigned to 'axis 0x17').
Additionally, only the LT button seems to alter the BRAKE axis (increases the value) and yet the RT button doesn't do anything at all (does not decrease the value even if I hold LT).

I'm using an Xbox One Wireless Controller (uses Bluetooth) on a Galaxy S7 freshly updated with Oreo.
Gamepad Tester is reporting my gamepad is using the Vendor_045e_Product_02fd.kl file for the mappings.

Hey! My xbox controller syncs up fine and for the first couple of runs, worked fine.  Then my android tv forgot the device and had to resync.  Ever since the triggers are the wrong way round and i also have to resync the device everytime i start my controller or tv.  Does anyone know how i can fix this?  Seems weird that it actually worked for a time.  Im also runnig steam link through the android tv.

I made my own key layout but the triggers still don't work. Any help?
Any way to change the triggers to buttons?

update: got the triggers working but the left trigger is also bound to the BRAKE axis, the select button now works as intended

I was able to get it working with proper mapping by updating the firmware for the controller. I connected it to my PC then opened the "Xbox accessories" app from the windows store and followed the instructions to update.
No root required.

Do the triggers work?
Does the select(view button) work?

Just fired up Minecraft on my phone (mainly because it shows you what buttons are supposed to be what and you can rebind controls if needed.) and both triggers and the menu/select buttons work great.
No root or modifications to my phone.

This bug should be fixed in P, see:
https://android.googlesource.com/platform/frameworks/base/+/refs/heads/sdk-release/data/keyboards/Vendor_045e_Product_02e0.kl
Therefore, marking this as fixed.

Now, I am seeing in comment #41 and comment #44 that there's a slightly different device with product id 02fd. Is that a newer model? Where did you buy it?

Hello, gamepad works like a charm on Android running Pie, but vibration is only supported via USB connection. Is it possible to add vibration support over bluetooth as well?

Can you please file a new bug, provide some more information, and link to it here?

This is broken again with Android 10
Triggers are not mapped at all
Start/Select is incorrectly mapped
Right joystick is mapped to buttons
X and Y are flipped

Gamepad: 02E0 product ID according to Gamepad Tester
Pixel 3: Android 10 Build Number QP1A-191005.007

I am using Android 9, and it has mapping problems over USB now even. Right analog stick is being detected as if it's just being constantly pulled up-and-to-the-left, and pressing the triggers actually moves what's supposed to be a right analog stick.

I made this for xbox 360 wireless controller works in android 9

Regarding comment #53,

could you please let us know which device you tested your layout on, and whether the device has CONFIG_XPAD enabled in the kernel?

Same i tested my wired xbox one controller with a usb pord to my galaxy a50

Is this cool? I want it!

.

#51: That's the kind of thinking that stifles innovation. Where was this epidemic of people blaming Google throughout the Oreo era when OMS was merged and was open to third-party overlays?

Thats the good idea to add a separate permission for managing themes . let the advanced users manage their overlays . so will not waste 1000 s of developers hard work .

#53: Exactly how do third-party overlays applied through Substratum and related apps present a security risk? Can you describe how the code works? Can you demonstrate how these overlays would penetrate Android security and compromise a person's device or personal data? If you don’t have concrete evidence or examples of vulnerabilities that can be exploited by such overlays then you might not want to make such a sweeping statement.

Dont remove substratum

Ok i won't

El 9 mar. 2018 6:15 AM, <buganizer-system@google.com> escribió:

Bring back the overlay themes🙌🏻🙌🏻

主题

+1

Please Google don't remove OMS. Don't be like Apple please.

I'm not interested.


On Mar 9, 2018 at 5:23 PM, <buganizer-system <buganizer-system@google.com>>
wrote:

Replying to this email means your email address will be shared with the
team that works on this product.

https://issuetracker.google.com/issues/74354703

*Changed*

*un...@gmail.com <un...@gmail.com> added comment #67
<https://issuetracker.google.com/issues/74354703#comment67>:*
Please Google don't remove OMS. Don't be like Apple please.

_______________________________

*Reference Info: 74354703 [Developer Preview Android P] Feature Request: Do
not enforce platform signature when installing overlays for OMS*
component:  Android Public Tracker > Android Developer Preview
status:  Assigned
reporter:  qi...@gmail.com
assignee:  ad...@google.com
cc:  qi...@gmail.com
type:  Bug P3 S3
blocked by:  74373527 <https://issuetracker.google.com/issues/74373527>
hotlist:  Platform <https://issuetracker.google.com/hotlists/461195>


Generated by Google IssueTracker notification system

You're receiving this email because you are subscribed to updates on Google
IssueTracker issue 74354703
<https://issuetracker.google.com/issues/74354703> where you have the role:
starred.

Don't kill Substratum!!!!!!!

Dear Google please bring back oms support, and also make a poll, and see if we want substratum or not,

Please,dont kill overlay custom

People, please stop with all the "please don't" kind of messages. Rather, star the issue, that way nobody will get e-mail spam, and the dev team will see that it's an issue to be worked on. Posting here every few minutes just increases the amount of spam all of us who've starred or commented on this issue, and to be honest, it's freaking annoying.

So again:

✅ - Star the issue
❌ - Comment non-technical stuff on the issue

.

It should be up to the manufacturer and NEVER upto the user to customise OMS, at least on stock ROMs

Also I don't care about the adb hackery. Google is doing the right thing here

It is very much possible to see malware that could elevate to system and grant itself the permission to install overlays. Google of course knows that this code is vulnerable and they are trying to protect it by enforcing that into the system developer can make overlays

#74:

If a malware has elevated so many rights that it can execute ADB commands without an actual ADB connection, you have much larger issues than a stupid overlay being applied to your phone. Your arguments are laughable at best. The current Oreo implementation of OMS poses no security risk whatsoever.

#FreeSubstratum

#freeSubstratum please.

#74:

I'd love to see you actually talk code and permissions. You are currently making statements about something you don't know even a small bit about. If you think modifying /res or /assets in app can cause a security risk, you have to be just stupid. You are currently just a Google fanboy who came here to defend them, when face it they fucked up, and that's why we are here to tell them to fix this.

Also to all the the people with the "+1" or "please" comments just stop it, you aren't helping you are just in the way of the actual discussion

#51:

I'm interested in seeing a burning phone, just from the use of Substratum on it. "Crashing and burning", only happens if you can't read and use unsupported overlays also even if you accidentally do it takes exactly one or two adb commands to disable that overlay and try again while reading the second time

I think it's important for Android users to customise and personalized their smartphone and by restricting this is it is the most basic value of Android so I believe Google should have substratum themes or custom overlays to be installed without any restrictions just like in Android Oreo.

The beauty of android is in it's customization and you took it away, please add overlays back...

Please keep us free #FreeSubstratum

What you don't understand is that enforcing platform signature for system partition is a security feature. Otherwise, your Substratum becomes a vehicle for all kinds of apps using Substratum read/write rights to hack your phone. Substratum has root either by way of dumb developers making it "rootless" by granting root rights to the app in their roms, or via root rights given by a user. In either case, you are exposed.

Cudos to Google for catching up with Substratum and eliminating the threat.

#83:

You're wrong.

Substratum on Oreo with Andromeda **DOES NOT** require root. It needs a few scripts to be run from ADB to allow the app to manage overlays, that's it. Neither the ROM nor the user grants it root rights, it grants rights to the app to install and apply overlays.

This widespread stupidity has to stop, especially from people who know little to nothing about the topic, but spew their stupidity on public forums for fear mongering.

#83: I think it's YOU that obviously does not understand how Substratum and OMS work. At all.
Substratum worked rootlessly even on stock ROMs, not just custom ROMs. And it will still have root rights. That is hardly the issue.
In case you don't know, overlays don't have any read/write rights or anything of the sort. They can just override resources like drawables and colors for apps.
Please do your research before embarrassing yourself in public.

Google I love your guys's software and have been using Android since the G1 on T-Mobile so many years ago.

I have always rooted my devices and gone crazy on them in order to make the screens dark as my eyes are very sensitive to the light.

I'm a disabled US Army veteran and like many others I've spent a lot of time in various deserts around the country or the world and have light sensitive eyes due to that. Being able to have the easy capability of installing a dark theme through substratum and Andromeda is a must for me.

I have a pixel 2 XL that I haven't unlocked or rooted because this has been available. If you take that away then I have to start busting into my phone again which nobody should have to do to do this.

Please consider this as a accessibility feature for those of us with light-sensitive eyes. At work we would call this a reasonable accommodation. If I can get the federal government to approve dark themes for use in Chrome and other places, you guys can do this for us.

Thank you.

Google, why are you taking freedom from people day by day.

What happened to "be together, not the same"?

To those who read this far, please support us by signing this petition, and starring our request in Google's issue tracker. Thank you. #FreeSubstratum #FreeAndroid

Well ,I received a lot of notifications regarding this, so thought I would try to clarify the issue:

1. For people who say it is a security issue: Using overlays is not a security issue at all, even in oreo it worked without rootand was hidden behind an adb command. If a malware has elevated so many rights that it can execute ADB commands without an actual ADB connection, you have much larger issues than a stupid overlay being applied to your phone. Your arguments are laughable at best. The current Oreo implementation of OMS poses no security risk whatsoever.
Also, as previously suggested, google can add an additional permission (like android.permission.MANAGE_OVERLAYS) to explicitly allow applications to install overlays by giving users something like a runtime permission dialogue. This would ensure security as well as customizability.
Also, since android currently does not have native theming support or a dark mode, substratum is the best solution for people with oleds, so i dont think google will remove it.

2. Its a developer preview: You must also consider the fact that it is the first developer preview and there are 4 more to come before the final release, so you never know what features can be added or removed (google can even make overlays officially supported). This change might also be because the preview build is unstable and using overlays might have some side effects(pure speculation), so google might have a reason for it. The beta program is for getting user and developer opinion but making useless comments about requesting google and whining about google becoming apple will do no good, it will only increase the spam, so just star this issue and be patient. We should wait for the next previews before deciding anything

On Mar 9, 2018 7:20 PM, <buganizer-system@google.com> wrote:

It'd be a huge setback if you took people freedom to theme and customize their mobile devices. Isn't that one of the biggest things about Smartphones? Think Google, c'mon.

With all the stricter rules in place, effectively crippling software like Substratum, what's next kick cripple Tasker for doing its job? With more and more options which I love on Android gone, I might as well switch to iPhone. Android P is starting to look like iOS anyway. I know security is an issue for Android, but start at home by making the Play store a safer place.

Notches and no themes. The distance between Mountain View and Cupertino is shrinking. Please do not prohibit users from adding themes from Substratum or Andromeda. Flexibility is the reason to choose Android over iOS. Let's not screw this up.

Let's keep Android Customizeable Google. I didn't leave Windows Phone for Android to put up with this nonsense. The people want dark UI and many other colors. "Give us Free!" #GiveUsFreedom!

I totally agree with #90 .

Guys we all are pissed, but please stop spamming this thread with the complaints. Google knows this. Such spamming will do no good and it even irritates the developers.

We don't want to get emails from here every few hours. Especially if the comments are basically the same in different words.

Please be patient. I'm sure this matter will be made clear before P's official release.

Thank you.

#83:

Please.. I've had enough retardation here. If you have got something to prove give code, logs and examples. You are talking, but even you don't know what you are talking about. Either don't say such things in public, because you are fucking hiliarious. Andromeda doesn't have any read/write permissions all it can do is compile overlays and use a rootless operation to move them to the directory where they have to go. Coming here to defend Google when they fucked up, is stupid. It happens when OEM make stupid moves, but that's why there is a community to lead them to the better. if you think Substratum poses ANY security risks feel free to not use it, but lying about what is does is stupid of you. Just don't, rather go and research about OMS and Substratum.

Also they people with the stupid comments this is not the right place for those. Go and sign the petition, instead of crying here.

Also regarding the one who suggested the MANAGE_OVERLAYS permission that's a great idea, but maybe it would be a bit better if it required Device Admin instead.

We need custom overlays in Android P.
Also Android P developer preview, is using Flux substratum theme, that's shame.

https://www.change.org/p/adam-lesinki-google-let-android-users-install-custom-overlays-again-freesubstratum-via-chris-kardas

Alphabet, Google, Android, Whoever you guys prefer being addressed at these days,

Locking OMS support to rooted users only is not a Customer friendly decision. if you need it to be more security conscious, fine, but find a better way.

Why the hell would you remove substratum support.  Please remove your heads from your arses and give the people what they want.

The security excuse is a nice attempt, Google, but you forget that the people who ACTUALLY enjoyed using the OMS features you yourself built into 8.0 Oreo, aren't the average consumer and won't buy that excuse.

Android was supposed to be for those of us who like to customise. "Be together, not the same" remember?

Well, killing access to things like Substratum without root by thwarting OMS, and forcing users to root phones and install ROMs (thus voiding warranties and possibly bricking phones) goes precisely AGAINST that idea of "not the same".

Revert this terrible decision, and allow us to get Substratum working like before. Heck, if necessary, reach out to the Substratum theme and work WITH THEM so that you can build something that addresses those "security issues" and keeps the customisation options intact.

And consider this: we, the people raising our voices against this decision might be an insignificant number amongst the billions of Android users. HOWEVER, we are the developers and the enthusiasts that actually TELL those billions to buy Android phones instead of iPhones. We are the ones who are there for those billions to help them with their Android devices on day-to-day usage. If we stop seeing reasons to tell people to buy Android phones...we will stop. And you know what happens after that? Well, ask Internet Explorer.

You're making Android more and more like iOS.
If you continue, there'll be a point - extremely soon - where we will stop needing Android at all. If it works like iOS, we might as well just all go to iOS anyway.

Please don't remove substratum theme system necessary files from Android P.

I believe that everything has been said here that is more accurate on this subject. So instead of repeating myself, I really want the Google development team to read all of this.

Sony had a unmerged commit on the aosp Gerrit that allowed third party overlays to be used but allowed developers to whitelist what resources can be used, LG actually uses this in their nouget builds, while I don't suggest whitelisting, this security commit could be instead changed into a blacklist so developers can list what resources to not let be overlaid and allows developers to have a consistently themed app that's expected.

I see people bringing up a overlay can crash a app and that's their security concerns even though there are non malicious apps that have done this.
There is already a solution to overlays crashing apps, in custom ROMs, we had a overlay crash detector that if a overlay caused a crash, overlays on that app would be disabled.

Another feasible option would be to block specific types of resources from being overlaid, CyanogenMod theme engine actually did this and could block things like strings being overlaid

Platform key signed is a bit overboard for security and there are many different ways security could be improved on OMS while leaving it available for third party theming.

Any of the suggestions I posted above would remove any of the security concerns that have been listed here and other places.

Everyone coming from Reddit or XDA.

Please refrain from posting useless comments that directly attacks Google themselves unless you've anything good to say about this feature request.

Plz allow overlays to work android is all about  customisations so don't try to kill it, hope u un restrict the overlay & support for further improvements

Google, just please.. our life need colours.. need variation.. not static.. Disallowing the overlay is not cool at all..

Google, if you remove OMS and continue with the shitty UI changes you seem
to be "introducing" (read. Copying from iOS and EMUI) in Android P, I'll
have to sell my Pixel 2 and get a different phone.

With both of these changes you're throwing your existing user base, who
bought your Nexus and Pixel devices specifically because of their clean and
elegant software design, under the bus in a vain attempt to attract iShits.

And yes, this is the proper place to tell you this.

On Fri, Mar 9, 2018, 3:54 PM <buganizer-system@google.com> wrote:

--

Sent from Inbox

Why take away the liberty from people to modify how their looks like for them? Aren't you supposed to be encouraging it? Don't take away substratum from users.

Unstarring this issue due to people spamming with useless comments and complaints that have already been posted.

Unstarred this issue, got sick of the email spam for every "please bring OMS back" post. Honestly, I hope Google decides to keep it the way it is, blocked, because people can't follow simple instructions of starring the issue and not posting. And I hope everyone who starred this issue, will unstar because the amount of email spam is too damn high! Here's another email in your inbox regarding my post.

If there's a reason end users love android; that's it being Open Source.
The initial DP1 of Android P shouldn't have done this. Stock android is nothing without customizing it to users preference.

we need substratum

What happened to the whole #BeTogetherNotTheSame movement

Google don't Block substratum.

Ok Google "#FreeSubstratum"

Don't block substratum #freesubstratum

We need substratum please don't block it google.

Substratum needs to stay!

Seems like none of you actually understand what implies allowing "overlays" to 3rd parties.
They are able to change every config exposed by the android framework, they can change the brightness values of your device, tell android your device isn't sms/voice capable AND it can change some colors.
The drawbacks of this feature are higher then the "benefits" of allowing some colors/theme changes compared to what they can do to your device.
Security over personalization must win.

If Android P does not support OMS, or we say Substratum theme, I will never upgrade to Android P

Lol. For clarification, oms was not removed. It's just that you can't install overlays unless you do some hacky stuff. XD

#120:

We discussed security multiple times. The answer is not limiting the whole OMS to system-only apps, but making it secure for people to use. Or what's the next step, Google removing the option for custom launchers, or widgets?

You need to understand, that the reason many folks choose Android over IOS, is for choice and customisation and not because they wanna use Google services. What possible objection can Google have with rootless theming? This is one of the worst regressions I've witnessed in my 8yrs on Android.

120#:

We all clearly see you aren't a themer and don't know a shit about overlays. Either next time don't embarrass yourself in public or give examples. Change some colors I totally agree, but changing brightness or SMS/voice capabilities is complete bullshit. I'd really love to see your implementation of a theme that can edit my build.prop and so tell my device it doesn't have SMS/voice capabilities... But oh wait that's not possible with overlays.

Next time some research could help you

#125:

In theory it is possible to overlay framework XMLs, including the capabilities XMLs used by the framework to identify certain values. This CAN pose as a security threat, hence why OMS needs to limit some of the overlays - either by setting those resources overlayable only by the currently implemented system/platform signed packages, or not at all.

#120:

Nice FUD.

Why do people not research anything anymore?

Can you guys stop being a bitch.
Thought Android was open source...

#125
> Next time some research could help you
Oh you, did you ever try to do something more complex then applying a theme? I know what I talk about, apparently you don't.
The only sane person here is #126

Yes,we need substratum

#129:

Guess what.. yes I did I have modified all kinds of system parts of my device with Substratum and I can tell you, you sound hilarious. If you did you'd know what you are saying is bs. If you think there is indeed a security risk show an example or just quit being retarded. All of the Substratum groups are laughing at you.

Would love to see your overlay attached as a file here. That's when your opion could actually be proved or busted.

#126:

In theory that is true, but Substratum only modifies /res and /assets, so there's nothing which could possibly be a security threat there. And if you've ever looked at those XMLs by yourself (which you clearly haven't) I suggest you do and then tell me which of those values are your "security threat".

Same goes for you. Would love to see an overlay attached here, so I can look into what it does and how it is a security threat. And using yes research will indeed help you maybe do that instead of using the '>'.

We need custom themes or at least a dark mode option.

Keep substratum!

All of you need to stop, right now. This is a BUG REPORT forum. None of you
can seem to read. STAR THE ISSUE AND MOVE ON. This is not a petition, it's
an AOSP bug tracker. Keep it up and Google won't even bother, they'll just
mark it "working as intended".

Just a reminder that this isn't Google fighting Substratum, this is Google
fighting *unsigned overlays*.

Please, for the love of God, stop commenting on this so the email spam
stops. I love that you're all so passionate about this issue, but
constantly commenting is detrimental to your cause.

#132

As I said, it's a POSSIBLE security risk. It does not necessarily apply onto AOSP, but more likely to cause issues on manufacturer modified versions.
As Substratum dev MSFJarvis has explained to me today, I quote:

"The security issues around overlays are a bit more subtle. SystemUI has a component it calls the SystemUIFactory class - pretty self explanatory. SystemUIFactory is defined in config.xml, which is under OMS's abilities to override. If you set it to null, SystemUI will never start up and rescue party won't recognise that either apparently. This is the worst I can think of right now."

Technically, OMS overlays can only override files in /res and /assets, in system apps, installed apps, and framework-res. This limits the exposed points to a handful:

- Resources, such as:
-- Layouts
-- Drawables
-- Animations and Interpolators
-- Translations
-- Values defined in resources
- Assets

Assets are in most cases HTML files or fonts. Former can have some chance of having malicious code injected (but then again, the same can be applied for websites, should Google restrict browsers on Android too?), fonts are usually not exactly known for exploits.

Resources... There the malicious injection is aimed more at the user than the actual system. Layout changing won't do much as long as there's no code behind it, so most of the changes are cosmetic - changing an icon's color, size, padding, position, etc.

OMS also requires you, if you change a style, to include all existing attributes. You can't just remove them and bam, done. What you can do with it is make a copy, and change their values.

This can result in malicious overtake too, but it's a multi-step thing. The only thing I can think of is replacing an URL in an app's resources - note, the URL **MUST** be in an XML, and not hardcoded. Then the user needs to launch said app, and go to a screen where said URL is used. This requires very specific targeting of the app and the user, AND it requires the user to install said layout. Chance of encounter - really low.

Also, sorry, I haven't done much platform development in the past ~3 years, and completely mixed up stuff. Indeed the capability XMLs are not stored in framework-res, but in a separate folder, making it impossible to change them via OMS.


The solution I see here is Google reaching out to the Substratum team (or vice versa), and them working together for OMS to be more secure, integrated, and easy to manage via Substratum or any other app that shows up to manage the layouts, if there will be any.

#135:

I agree. The pointless "me too" kind of comments have to go, but I believe technical discussion should stay.

#136

I agree entirely. And yes, this could cause security issues, but not in any
simple manner.

I think [.projekt] have been trying to collaborate with Google for a while
now. It was one of their long-term missions. Unfortunately, perfect
solutions don't always exist, as it seems Google is much more focused on
the mainstream, who are wary of Android security, than working with
developers that create anything more than surface level apps. Part of that
could have been because of the competitive atmosphere Cyanogen created
(they had their Theme Engine, too).

As much as I want to support this issue, all the spam is forcing me to remove the Star. If we want Google to keep this we need every star we can get but spamming is only going to make everyone remove their star to stop getting the pointless emails. XDA and others said exactly not to do this and you guys are idiots for not leaving, maybe you deserve to have this taken away since you clearly can't follow simple instructions to try and keep it around.

#136:

Looks like you'll need more research. No kinds of classes are located on either /assets or /res. Also the screenshot I attached has got that person himself's reply from a few minutes ago, see it for yourself. Thanks in advance. Would really appreciate if all the lies being spead here stop.

Also to all the people saying that they are un-starrijg because of spam. There's a mute button in Gmail, so maybe do that instead. If you think the few un-stars from people who can't even use an email app will matter, no they won't.

you can't do that in the inbox by gmail app, this constant spam is freaking annoying, i'm out

I demand pure black interface for UI and other Google applications...

We can manually or automatically hide navigation bar like we have seen Samsung S8 Note8 S9 ( Samsung Experience )

Professional camera setting such as adjusting ISO, Aperture, Exposure.

h.265 10 bit or h.265  video encoding for camera ( Since new Pixel 3 series will came with Snapdragon 845 which supports 10 bit h.265 video capture.

10 bit still image capture too .

Native support for ExFAT or NTFS storage formats.

Partial selection( for copying) in a SMS . Currently we canly only sellect whole SMS not partially .

I've been using Android P with my Pixel 2 XL and Pixel XL devices. .

That is all as of now :)

Thanks


Erdal

Please add Substratum support for Android P.

let us tweak and especially theme our properties. sooner or later, as it has always been in the past, big players feel too safe and go the one stop too far and in the aftermath trigger development of new and free tools wich ultimately lead to their doom. i don't necessarily and only mean software and/or technology, what i mean is a pattern that goes back thousands of years across all kinds of things.

Please add Substratum support for Android P.

#139:

What I told Jozsef is correct and verified by me and Nicholas Chum personally. We would have liked to utilise this thread as a discussion platform with Google to work together on minimising this and similar exploitation vectors and formalising the access to the overlay manager service for third party apps under a documented public API with runtime permissions enforced. If only people would stop the non development spam...

Edit to #140:

Well I apologise I might have been wrong about that config.xml, and it is indeed in SystemUI and it could break Rescue party. Even this which I'm sorry about I do indeed think that before you install something you are confident it is trusted and if it could possibly a security risk that would be trough an app you have given adb permissions to. Maybe there could be some troll "themes", but except those I can't really think of anything else, unless you give adb permissions to random apps. Again sorry

Please bring back Substratum support to Android P, we really need it.

Please add Substratum support for Android P and future versions

Android is open-source project.

Why not add substratum into Android P instead of blocking it.

Please add Substratum support for Android P and future versions

I've been a loyal Android user and developer since the Motorola Droid A855. I have owned every Nexus device ever made. You promised to never end the Nexus program and slapped us loyal users and developers in the face. If you block Substratum, I will literally boycott all Google products and services. Words cannot describe how upset I am right now.

Hi, can we STOP treating this like fucking Twitter?  Unless you have something RELEVANT to the bug (not an opinion, anecdote, or other comment) DON'T POST HERE.  Star the issue and move on.

One way to make sure the problem DOESN'T get fixed is to spam the everloving hell out of the comments section... all that happens is people get fed up with the useless emails notifying them of your useless comments, then they UNSTAR the issue, thus lightening its severity.

please keep this!

support substratum

Plz add it

Dear Google, I understand there must be a valid reason for preventing Stock OMS users from utilising custom overlays. All I'd like to say is please find a way to sort whatever maybe the reason not to allow custom overlays and keep the loyal Google / Android OS users a little bit more satisfied (We already love Android OS enough for all its pros and revolutionary changes it brings to the end user). Thanks and regards.

Been waiting for a dark material design theme natively in Android for ages. Now also removing substratum support? I can't understand why they would deliberately keep ignoring community need for native theming

What! now android is also restricted us by theming it , tell me then what is different between ios and Android .. Please don't do this.

Why so hate for theming,Google???

Support Substratum! #MakeAndroidGreatAgain

Support substranum... Android is all about modding and customization... Let it be that way...

Pls bring back OMS support on Android P!! Plus redesign Android P again, it is so iOS-ish. Give also credits to the one that designed Android P's settings - Flux White Substratum Theme by giannisgx89

ANDROID 8.1 WILL BE THE LAST AND BEST ANDROID YET 😭😭

Google, you are a disappointment!

You already broke our eyes because of all the white theme in Android and our only hope to get dark theme is Substratum. But now you're also breaking our heart because of this nonsense move!! GOOGLE PLEASE WAKE UP

Can everyone PLEASE STOP COMMENTING???

Disabling custom overlays would mean you would be removing the feature
android is famous for.....
We have to be better than apple....not become apple....please enable
substratum.

On 11-Mar-2018 3:04 PM, <buganizer-system@google.com> wrote:

Android is known for customization, but with current moves by Google will kill the android's popularity

*rips flux white*
*removes substratum*
gg google



but srsly tho, we need substratum _/\_
or else you wouldn't get any new theme to copy for android q.

i love Substratum