IssueTracker

Thank you very much for reporting this issue, Jack. Looks like the issue is caused by somewhat unnecessary and contrived logic in apksigner.bat, which is special-casing -J* parameters. Unfortunately, this logic doesn't handle whitespace containing parameters, even those which aren't -J*.

I've uploaded a tentative fix https://android-review.googlesource.com/#/c/394238/ for review. The patched apksigner.bat is attached. This fixes the issue on my Windows 10 box.

Jack, please test the fix in your environment and let us know whether it works for you too.

Confirmed, that fix works. Thank you for the quick turn-around on this.

Project: platform/tools/apksig
Branch: master

commit b293b2087837853e32a1cff008d58644dbbd4cc2
Author: Alex Klyubin <klyubin@google.com>
Date:   Wed May 10 16:53:25 2017

    Handle whitespace when removing -J* parameters in .bat
   
    apksigner.bat contains special logic for -J* parameters. This logic
    was not designed to handle parameters containing whitespace. This
    commit fixes the issue. It is unclear whether this -J* logic is even
    needed. So, if it keeps breaking stuff, we should probably simply
    remove it.
   
    Test: apksigner sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk
          Fails with FileNotFoundException instead of "a was unexpected at this time"
    Bug: 38132450
   
    Change-Id: Ice3294e9993b075533c77d94eb870cfd35a65bbc

M       etc/apksigner.bat

https://android-review.googlesource.com/394238
https://goto.google.com/android-sha1/b293b2087837853e32a1cff008d58644dbbd4cc2

Project: platform/tools/apksig
Branch: master

commit 0f88b97634034673f062a8ac6c3dab7d3d9befe3
Author: Alex Klyubin <klyubin@google.com>
Date:   Thu Jun 22 09:43:22 2017

    Bump apksigner version to 0.7
   
    Changes since 0.6:
    * Fixed a bug in whitespace handling in command-line parameters in
      apksigner.bat. https://issuetracker.google.com/issues/38132450
    * Fixed a bug in JAR signature verification when multiple digests
      are present for the same named entry in MANIFEST.MF.
      https://issuetracker.google.com/issues/38497270
    * Honor android:targetSandboxVersion (introduced in Android O) when
      verifying APKs. When android:targetSandboxVersion is set to 2 or
      higher, the APK is required to be signed with APK Signature Scheme
      v2.
    * When signing, reject APKs with CR, LF or NUL in ZIP entry names.
      Such names are not permitted by the JAR siging spec and are also
      rejected by Android Package Manager.
   
    Test: apksigner version
    Bug: 38132450
    Bug: 38497270
    Bug: 36426653
    Bug: 62211230
    Change-Id: Ifa120b0e43b458c99c3da6fde1136e0cbb92caee

M       src/apksigner/java/com/android/apksigner/ApkSignerTool.java

https://android-review.googlesource.com/420784
https://goto.google.com/android-sha1/0f88b97634034673f062a8ac6c3dab7d3d9befe3

The fix has been released in apksigner 0.7, released as part of Android SDK Build Tools 26.0.1.

Good news. Does this mean that Wallpaper based automatic  Theme switching will be removed? That was the dumbest thing i've ever had to endure on my phone.

And if that get's removed there's no reason to keep the horrible Wallpaper colour based Tinting applied in various places. The sooner that is gone the better.

Also any chance of Settings and Gmail apps getting Dark theme?
The look of older Android versions with dark theming and OLED was perfect, it'd be amazing to get back to that

Also need transparent mode in launcher settings.. transparent looks very awesome and wallpaper looks very transparently on the back side of the menu.

Does "Dark" mean black so that AMOLED screens can benefit, or is it a useless dark grey?

Now how about a dark theme for Settings and system elements like notifications & toasts. A dark theme option doesn't have to accommodate any and all Play Store apps or even all Google apps. No theme needs to be 100% compliant or consistent. App developers can take care of themselves.

I wouldn't call dark grey "useless". Maybe useless in terms of what YOU are wanting, but it's dark grey is easy on the eyes, which is plenty useful for me. Good on Google for doing this.

Why request it in the launcher, instead of in the OS itself?
There is no reason only the launcher should be affected...

Dark Mode should applies to everything, no exception. We don't want to see
anything that has white background. That's the purpose of Dark Mode.

On Wed, Jun 13, 2018, 12:54 PM <buganizer-system@google.com> wrote:

I long for "AMOLED Black" to be an option under theme in settings.

Since my medication has made me light sensitive, I've used "Invert colour" which makes the main Google apps look fantastic!
Though isn't as good as good as themes because pictures, videos and other apps are also inverted.