Fixed
Status Update
Comments
il...@google.com <il...@google.com>
al...@gmail.com <al...@gmail.com> #2
Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)
Android bug report capturing (kindly share complete bugreport)
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory.
Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
Android build
Which Android build are you using? (e.g. OPP1.170223.012)
Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)
Android bug report capturing (kindly share complete bugreport)
After reproducing the issue, press the volume up, volume down, and power button simultaneously. This will capture a bug report on your device in the “bug reports” directory.
Alternate method
After reproducing the issue, navigate to “developer settings”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Screen capture of the issue
Press the volume down and power buttons simultaneously. The image will appear in your gallery. Attach the screenshot file to this issue.
Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.
jo...@gmail.com <jo...@gmail.com> #3
Android build: N/A - firebase crashlytics doesn't provide that information. It happens on both Android 9 and Android 10.
Sample: N/A - it's a race condition can't reproduce it consistently
Frequency: ~1 %
Android bug report capturing: N/A - firebase crashlytics doesn't provide that information
Problem:
In BiometricFragment the mBundle is not always set - so when isDeviceCredentialAllowed is called the mBundle.getBoolean(BiometricPrompt.KEY_ALLOW_DEVICE_CREDENTIAL, false) throws the NullPointerException.
Sample: N/A - it's a race condition can't reproduce it consistently
Frequency: ~1 %
Android bug report capturing: N/A - firebase crashlytics doesn't provide that information
Problem:
In BiometricFragment the mBundle is not always set - so when isDeviceCredentialAllowed is called the mBundle.getBoolean(BiometricPrompt.KEY_ALLOW_DEVICE_CREDENTIAL, false) throws the NullPointerException.
vy...@gmail.com <vy...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0b2dee89f68e9ed41c9552a93fee72364253af41
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Nov 06 10:00:17 2019
Fix possible NPE with BiometricFragment method
The current implementation of
BiometricFragment#setDeviceCredentialAllowed() tries to get a boolean
from mBundle without first checking to see if mBundle is null,
potentially resulting in a NullPointerException. This commit adds in the
null check in order to make calling this method safer. It also adds a
unit test case to exercise this behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 142599311
Change-Id: I18e03f926ff03c53f8cf1812fbad46ea75db6a32
M biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
https://android-review.googlesource.com/1159943
Branch: androidx-master-dev
commit 0b2dee89f68e9ed41c9552a93fee72364253af41
Author: Curtis Belmonte <curtislb@google.com>
Date: Wed Nov 06 10:00:17 2019
Fix possible NPE with BiometricFragment method
The current implementation of
BiometricFragment#setDeviceCredentialAllowed() tries to get a boolean
from mBundle without first checking to see if mBundle is null,
potentially resulting in a NullPointerException. This commit adds in the
null check in order to make calling this method safer. It also adds a
unit test case to exercise this behavior.
Test: ./gradlew biometric:connectedAndroidTest
Fixes: 142599311
Change-Id: I18e03f926ff03c53f8cf1812fbad46ea75db6a32
M biometric/src/androidTest/java/androidx/biometric/BiometricFragmentTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
il...@google.com <il...@google.com> #5
vy...@gmail.com <vy...@gmail.com> #6
Re #5
Ooohhh...
Yeah, that is what I was thinking but I wasn't sure.
Thanks.
Ooohhh...
Yeah, that is what I was thinking but I wasn't sure.
Thanks.
wk...@google.com <wk...@google.com>
wk...@google.com <wk...@google.com>
wk...@google.com <wk...@google.com> #7
Long and Boolean support will be coming in a future release.
I'll re-open this for the remaining requests for Parcelable and Serializable.
I'll re-open this for the remaining requests for Parcelable and Serializable.
wk...@google.com <wk...@google.com>
il...@google.com <il...@google.com> #8
Parcelable support has been added and will also be available in alpha03. The only defaultValue available will be @null (indicating a null value).
We strongly recommend using Parcelable over Serializable and won't be supporting Serializable in alpha03. We'll be tracking the additional feature request for Serializable over inhttps://issuetracker.google.com/issues/111316353
We strongly recommend using Parcelable over Serializable and won't be supporting Serializable in alpha03. We'll be tracking the additional feature request for Serializable over in
do...@arctouch.com <do...@arctouch.com> #9
I'm doing this:
<argument
android:name="latitude"
app:argType="Double"
android:defaultValue="@null"
app:nullable="true" />
And getting this error:
Caused by: java.lang.ClassNotFoundException:Double
What about Double?
<argument
android:name="latitude"
app:argType="Double"
android:defaultValue="@null"
app:nullable="true" />
And getting this error:
Caused by: java.lang.ClassNotFoundException:Double
What about Double?
il...@google.com <il...@google.com> #10
Doubles are not a supported format for Android XML values. You can use argType="float"
gv...@gmail.com <gv...@gmail.com> #11
I found out that it possible to use wrappers like this: (in release 1.0.0!)
<argument
android:name="amount"
app:argType="java.lang.Double" />
Why not use Serializable in that case?
<argument
android:name="amount"
app:argType="java.lang.Double" />
Why not use Serializable in that case?
ju...@hotmail.com <ju...@hotmail.com> #12
LocalDate is Serializable, so Im trying to use it with
app:argType="java.time.LocalDate"
and its giving me an error:
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: java.time.LocalDate
at androidx.navigation.NavType.fromArgType(NavType.java:181)
at androidx.navigation.NavInflater.inflateArgument(NavInflater.java:191)
Im using desugaring so ... may that be the reason??
app:argType="java.time.LocalDate"
and its giving me an error:
Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: java.time.LocalDate
at androidx.navigation.NavType.fromArgType(NavType.java:181)
at androidx.navigation.NavInflater.inflateArgument(NavInflater.java:191)
Im using desugaring so ... may that be the reason??
il...@google.com <il...@google.com> #13
Re #12 - please star
Description
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: N/A
When specifying arguments for and a navigation action, there are only 4 options: "inferred, string, integer, reference"
Some arguments in my app use Boolean and Long and SafeArgs seem to only support "string" or "integer" (even if I manually put app:type="long"... it does not know what "long" is and falls back to "string")
Please add support for more types... especially Long and Boolean (you can "put" a lot more types into a Bundle)
I know I can manually add args to a bundle and then navigate... but I really want to use Directions from SafeArgs