Fixed
Status Update
Comments
su...@google.com <su...@google.com> #2
Hey, I would like to take this up?
ro...@gmail.com <ro...@gmail.com> #3
Hey, any help on how can I proceed forward.?
su...@google.com <su...@google.com> #4
Re #2,3 - We've just published our
Fragment have some existing lint checks in their fragment-lint
project, so some of the steps are already taken care of for you (and the existing Lint checks are a good place to look for code examples and testing strategies).
Thanks for offering to help!
su...@google.com <su...@google.com> #6
Thank you for the pull request! This has been added internally and will be a part of the next Fragment alpha release.
su...@google.com <su...@google.com> #7
I know the ticket is closed but ..
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)
if you call getLayoutInflater from onCreate method (not onCreateDialog) you may have a crash.
because getLayoutInflator goes to onGetLayoutInflater and then it can go to onCreateDialog (even though the entry point is onCreate dialog)
Description
Version used: alpha01
WorkManager exposes method for cancellation of work. However, I currently don't see how this could be used if the work has already started.
Arguably, being able to cancel an ongoing work is very basic and must have functionality. Not being able to do so will render the entire framework unusable in many scenarios. It can also negatively impact the end users (e.g. by consuming too much battery/bandwidth).
Cancellation mechanism should be given a very good thought. As a starting point for a discussion, I propose adding two methods to Worker:
1) protected final boolean isCancelled() - will return true if the work has been cancelled
2) protected void onCancelled() - will be called after WorkManager determines that a specific Worker needs to be cancelled. Default implementation will be no-op.