Navigation w deeplink not forming backstack as expected [79734195]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 15, 2018 09:23PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: Pixel w Oreo

Two issues for the price of one!

According to the documentation, "When a user uses the Back button from a deep link destination, they navigate back up the navigation stack just as though they entered your app from the app’s entry point." (

https://developer.android.com/topic/libraries/architecture/navigation/navigation-implementing#Deep-link)

I have a navigation graph which looks like [Home] -> [Articles List] -> [Specific Article]

I have a deeplink to [Specific Article]
<deepLink app:uri="

www.example.com/articles/{articleId}"/>

However when the app is opened via deeplink (adb shell am start -W -a android.intent.action.VIEW -d "

http://www.example.com/articles/456"), [Specific Article] is shown and only [Home] is in the backstack.

Following advice here (

https://stackoverflow.com/questions/50339826/android-navigation-library-deep-linking-how-to-synthesise-backstack) I created a group. My graph now looks like this.
[Home] -> Group([Articles List] -> [Specific Article])

However now deeplinking does not link to [Specific Article] at all! The app opens on [Articles List] with [Home] in the backstack.

I would expect either implementation to behave as per documentation, with the app deep linking to [Specific Article] with both [Articles List] and [Home] in the backstack.

--- Sample project ---
Attached is a sample project demonstrating both issues.

The nav graph is as follows:
[Home] -> [Article List] -> [Article (has deep link)]
\---> Group([Issue List] -> [Issue (has deep link)])

To deep link use the following commands.

Deep link to article:
adb shell am start -W -a android.intent.action.VIEW -d "

http://www.example.com/articles/456" com.example.deeplinkbackstackissue

Deep link to issue inside group:
adb shell am start -W -a android.intent.action.VIEW -d "

http://www.example.com/issues/456" com.example.deeplinkbackstackissue

DeeplinkBackstackIssue.zip

955 KB

Download

Comments

il...@google.com <il...@google.com> May 17, 2018 01:35AM

Assigned to il...@google.com.

il...@google.com <il...@google.com> May 21, 2018 08:37PM

Accepted by il...@google.com.

il...@google.com <il...@google.com> #2May 23, 2018 04:50PM

Marked as fixed.

interesting is thread creates for one number or for one contact? (one contact can
have more than one phone number)

[Deleted User] <[Deleted User]> #3May 23, 2018 08:10PM

Good question - since the "corrupting MMS" in this case comes from an e-mail address,
the thread is created using the sender's e-mail address. I'm looking through the
code now to understand how the SMS/MMS messages are stored in the SQLite database -
perhaps this sender's e-mail address or the sheer length of the MMS message causes an
mishandled corner case?

Let me know if I need to clarify further here...

dj...@gmail.com <dj...@gmail.com> #4Jun 12, 2018 10:27AM

Hello,

I just wanted to comment that I am having the same issue.

I only realized it was happening after I added a few new contacts or responded to
numbers that were not in my contact list before I received the
announcements@t-mobile.delivery.net... (i'm assuming this is the culprit)

As a result, any reply I make to someone that was newly added or not in my contact
list will not actually send to them (it just starts a thread that is listed as
announcements@t-mobile.delivery.net) and instead sends to the first number on my
contact list...(I have changed this to my own number...)

I don't want to hard reset bc then I will have to reinstall all of my progs...

If I don't reset, I will be annoyed with responding to all new recipients as if they
are a new number being entered into an sms, for each individual reply...

Please fix this...

Thanks

Nehemiah Richardson

ar...@gmail.com <ar...@gmail.com> #5Sep 18, 2018 06:06PM

This issue is really annoying.

As you can probably tell, it can get you into alot of trouble.

i.e. you texting one of your buddies a joke and your girlfriend ends up getting it
instead. Yeah. Not a happy time.

il...@google.com <il...@google.com> #6Sep 18, 2018 08:44PM

For those of you following this issue:

I need to have some test cases that "break" the phone. If you have experienced the
issue reported above, please copy/paste the entire txt of the "corrupting MMS" to
this thread (please feel free to X out any personal information that you don't want
posted here). Most importantly, we need the exact text of:

* The recipient
* The subject of the MMS (if there was one)
* The body of the MMS

Some of this info is available when you long press on the offending MMS and go to
"View Message Details".

As an example, the one I received was sent by "onlinebanking@alert.bankofamerica.com".

Also, if you or anyone else you know has been affected by this issue, please ask them
to leave their info here. I'm hoping that if enough of us leave messages, this will
get looked at by the Google engineers. Please also mention the link to this bug in
other forums that have been reporting this problem. Thanks.