Repackage transitive org.jetbrains.trove4j dependency [109894262]

Fixed

Feature Request

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jun 8, 2018 07:58AM

3.1.3
3.2.0-alpha17

The `com.android.tools.lint:lint` [0] artifact depends on a repackaged version of uast (`com.android.tools.external.org-jetbrains:uast` [1]) which depends on a repackaged version of intellij-core (`com.android.tools.external.com-intellij:intellij-core` [2]) which in turn depends on a Jetbrains fork of trove4j (`org,jetbrain.trove4j:trove4j:20160824` [3]). The issue with this is that trove4j is only available on JCenter and not on Maven Central. Due to various issues in the past months we'd like to avoid using JCenter. Could you start repackaging the trove4j artifact and host it on

maven.google.com like you did with uast and intellij-core?

[0]:

https://dl.google.com/dl/android/maven2/com/android/tools/lint/lint/26.1.3/lint-26.1.3.pom
[1]:

https://dl.google.com/dl/android/maven2/com/android/tools/external/org-jetbrains/uast/26.1.3/uast-26.1.3.pom
[2]:

https://dl.google.com/dl/android/maven2/com/android/tools/external/com-intellij/intellij-core/26.1.3/intellij-core-26.1.3.pom
[3]:

https://jcenter.bintray.com/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom

Comments

uc...@google.com <uc...@google.com> Jun 8, 2018 09:45PM

Assigned to tn...@google.com.

ga...@gmail.com <ga...@gmail.com> #2Oct 23, 2018 08:39PM

Sorry for pinging, but jcenter seems to be causing issues again today for many developers.

tn...@google.com <tn...@google.com> #3Oct 26, 2018 11:06PM

UAST and intellij-core are licensed under the Apache license which made this easy; trove4j on the other hand is LGPL which makes me more nervous about just repackaging; I'd need to have somebody review what the rules and implications are.

ga...@gmail.com <ga...@gmail.com> #4Oct 27, 2018 06:09AM

As an alternative to repackaging could you ask Jetbrains to push trove4j to maven central? I don't know the reasoning for why it isn't on there but maybe that's easier.

xa...@google.com <xa...@google.com> #5Dec 2, 2020 07:06PM

Marked as fixed.

Lint in AGP 7.0 / Studio 2020.3 now uses org.jetbrains.intellij.deps:trove4j:1.0.20181211 which is present on maven central.

ep...@gmail.com <ep...@gmail.com> #6Feb 3, 2021 08:55PM

With JCenter set to turn down within 3 months, would you consider backporting this to earlier AGP releases?

https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

tn...@google.com <tn...@google.com> #7Feb 3, 2021 09:06PM

Yes, we'll do it for 4.2 (still thinking about 4.1.)

mi...@gmail.com <mi...@gmail.com> #8Feb 4, 2021 01:44PM

please think also on 4.0.2 I cannot use 4.1.0 because of the broken flavors. Please just push the old version to google()

Message last modified on Feb 4, 2021 01:46PM

t....@gmail.com <t....@gmail.com> #9Feb 12, 2021 09:26AM

To guarantee the backward compatibility, wouldn't it be enough to deploy the org.jetbrains.trove4j dependency to the maven.google.com repository?

(I believe that there's a workaround too, using a Gradle dependency substitution rule in the buildscript to substitute org.jetbrains.intellij.deps:trove4j:1.0.20181211, which is in Central, and I believe contains the same code as org.jetbrains.trove4j:trove4j:20160824 judging by the GitHub repository history)

tn...@google.com <tn...@google.com> #10Feb 15, 2021 03:50AM

For now we're limiting maven.google.com to libraries from Google (and in particular, if I recall correctly, trove4j is licensed under LGPL which means some extra complications.)

Note by the way that JFrog has clarified they're not taking jcenter down in 3 months; it will be up until February 2022.

t....@gmail.com <t....@gmail.com> #11Feb 23, 2021 11:09AM

Fwiw, I confirm that a dependency resolve rule works:

buildscript {
    configurations.all {
        resolutionStrategy {
            eachDependency {
                // https://issuetracker.google.com/issues/109894262#comment9
                if (requested.group == "org.jetbrains.trove4j" && requested.name == "trove4j" && requested.version == "20160824") {
                    useTarget("org.jetbrains.intellij.deps:trove4j:1.0.20181211")
                }
            }
        }
    }
}

Same for a dependency substitution rule:

buildscript {
    configurations.all {
        // https://issuetracker.google.com/issues/109894262#comment9
        resolutionStrategy.dependencySubstitution {
            substitute(module("org.jetbrains.trove4j:trove4j:20160824"))
                .using(module("org.jetbrains.intellij.deps:trove4j:1.0.20181211"))
                .because("org.jetbrains.trove4j is not available on mavenCentral")
        }
    }
}