Fixed
Status Update
Comments
mo...@google.com <mo...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c5567dc9121066b3f1031d26e7ccc114a3be3d99
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Apr 20 18:01:12 2020
Initial InteractionState / Interaction implementation
Adds Interaction interface, and InteractionState, which allows folding the state from multiple Interactions into one State object.
Also adds InteractionState to Clickable and draggable.
In the future InteractionState will be consumed by ripple / other indications, allowing for indications that handle multiple Interactions, not just press. Additional work includes adding focus support to InteractionState.
Bug: b/152525426
Test: ClickableTest, DraggableTest
Change-Id: Icfe2590a97f5df73e999334b88dd69faa91651b7
Relnote: "Added InteractionState and Interaction, making it easier to build components that react to UI state changes such as press, and drag"
M ui/ui-foundation/api/0.1.0-dev10.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev10.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev10.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/gestures/Draggable.kt
D ui/ui-foundation/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
https://android-review.googlesource.com/1271883
Branch: androidx-master-dev
commit c5567dc9121066b3f1031d26e7ccc114a3be3d99
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Apr 20 18:01:12 2020
Initial InteractionState / Interaction implementation
Adds Interaction interface, and InteractionState, which allows folding the state from multiple Interactions into one State object.
Also adds InteractionState to Clickable and draggable.
In the future InteractionState will be consumed by ripple / other indications, allowing for indications that handle multiple Interactions, not just press. Additional work includes adding focus support to InteractionState.
Bug:
Test: ClickableTest, DraggableTest
Change-Id: Icfe2590a97f5df73e999334b88dd69faa91651b7
Relnote: "Added InteractionState and Interaction, making it easier to build components that react to UI state changes such as press, and drag"
M ui/ui-foundation/api/0.1.0-dev10.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev10.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev10.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/FoundationDemos.kt
A ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/InteractionStateSample.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ClickableTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DraggableTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
A ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/gestures/Draggable.kt
D ui/ui-foundation/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
an...@google.com <an...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8c7bd0ed6ebbfc6f21dcf133de4aff9d54be53e2
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Apr 23 19:17:38 2020
Marks InteractionState as @Stable, and fixes disposition
Bug: b/152525426
Test: n/a
Change-Id: I61d122dce3e4004702a6284e8a65e7dfb8b2a625
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt
https://android-review.googlesource.com/1294087
Branch: androidx-master-dev
commit 8c7bd0ed6ebbfc6f21dcf133de4aff9d54be53e2
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Apr 23 19:17:38 2020
Marks InteractionState as @Stable, and fixes disposition
Bug:
Test: n/a
Change-Id: I61d122dce3e4004702a6284e8a65e7dfb8b2a625
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt
mo...@google.com <mo...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 794b8b605fb07b94a5e3e25cc4273a32548cfe22
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Aug 21 00:23:42 2020
Adds a sample and doc clarification for ordering in InteractionState
Often in design systems (such as Material) the most recent Interaction should be the one represented by the system, but unfortunately `Set` does not have a guarantee of ordering. LinkedHashSet does, but is also mutable, which is not a contract we want for InteractionState, so instead we document this behavior and guarantee that ordering is maintained.
Also adds InteractionStateTest to verify this behavior.
Bug: b/161522042
Bug: b/146345816
Bug: b/152525426
Test: InteractionStateTest
Change-Id: Iac4b4c7f733788785454fc29bfe56ca2c479b294
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/InteractionState.kt
A compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/InteractionStateTest.kt
https://android-review.googlesource.com/1406607
Branch: androidx-master-dev
commit 794b8b605fb07b94a5e3e25cc4273a32548cfe22
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Aug 21 00:23:42 2020
Adds a sample and doc clarification for ordering in InteractionState
Often in design systems (such as Material) the most recent Interaction should be the one represented by the system, but unfortunately `Set` does not have a guarantee of ordering. LinkedHashSet does, but is also mutable, which is not a contract we want for InteractionState, so instead we document this behavior and guarantee that ordering is maintained.
Also adds InteractionStateTest to verify this behavior.
Bug:
Bug:
Bug:
Test: InteractionStateTest
Change-Id: Iac4b4c7f733788785454fc29bfe56ca2c479b294
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/InteractionState.kt
A compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/InteractionStateTest.kt
Description
As we moving towards modifiers looks like now LayoutNode.detach() should be calling this as well making sure the parent is invalidated when we remove from the tree LayoutNode which was drawing via DrawModifier as otherwise we can continue displaying this LayoutNode as it was not removed
WDYF?