Status Update
Comments
di...@google.com <di...@google.com>
je...@google.com <je...@google.com>
ga...@google.com <ga...@google.com> #2
The reason this has not been seen before now is that JDK-8272564 was done for JDK-18 and that it also require min API level 28. The reason the Espresso library expose this is that (most likely) internal Google build tools have JDK-8272564 applied generating invoke-interface
on Object
methods.
ni...@nrbtech.io <ni...@nrbtech.io> #3
Branch: main
commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Fixes:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
bi...@google.com <bi...@google.com> #4
Branch: main
commit 9e5692c8ce91b3ea3f4199740b41d57c097c9947
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:40:44 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
ni...@nrbtech.io <ni...@nrbtech.io> #5
Branch: 8.0
commit 875ac43330d4404d3c481d7395368ec19defff9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:48 2023
Version 8.0.33
Bug:
Change-Id: I675869c3c03cce5a0e7b367981e79e47ad1048ec
M src/main/java/com/android/tools/r8/Version.java
bi...@google.com <bi...@google.com> #6
Branch: 8.0
commit 7b9dea5b4c29b5aa9dde2e4a7db4cb28b68c9caf
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:32 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
ni...@nrbtech.io <ni...@nrbtech.io> #7
Branch: 8.0
commit 2a7c539ec35668c77b0eacb27612d7a5d8a2d11a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:21 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Bug:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
ww...@gmail.com <ww...@gmail.com> #8
Branch: 4.0
commit a53fc28f4b588c1e7c0df8c36faf9559292b1d0f
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:54 2023
Version 4.0.55
Bug:
Change-Id: I9dceedf684646380d8cff6f7af2eb3bcbd610a72
M src/main/java/com/android/tools/r8/Version.java
ww...@gmail.com <ww...@gmail.com> #9
Branch: 4.0
commit ce3a4742ffec584560975df35ddae726ebdad65e
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:41 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
bi...@google.com <bi...@google.com> #10
Branch: 4.0
commit 608e9673999593f6c107570c7cd1df6d55e20c3a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:31 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Bug:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
ww...@gmail.com <ww...@gmail.com> #11
Branch: 3.3
commit eac71359fb9cb7aff95a249d63470f266063733b
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:47:59 2023
Version 3.3.91
Bug:
Change-Id: Ie3a0ef7343ed24225c2053278399d98646a683bf
M src/main/java/com/android/tools/r8/Version.java
bi...@google.com <bi...@google.com>
ni...@nrbtech.io <ni...@nrbtech.io> #12
Branch: 3.3
commit d4e177e2634ad9732828160d1d9215a6a5507cb9
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:47:48 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
[Deleted User] <[Deleted User]> #13
Branch: 3.3
commit 57a11e5142249bde710d4a92c87d0b7612d0328a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:47:37 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Bug:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
ro...@miquido.com <ro...@miquido.com> #14
Branch: 8.0
commit 7b9dea5b4c29b5aa9dde2e4a7db4cb28b68c9caf
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:32 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
ww...@gmail.com <ww...@gmail.com> #15
Branch: 8.0
commit 2a7c539ec35668c77b0eacb27612d7a5d8a2d11a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:21 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Bug:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
bi...@google.com <bi...@google.com> #16
Branch: 4.0
commit ce3a4742ffec584560975df35ddae726ebdad65e
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:41 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
ww...@gmail.com <ww...@gmail.com> #17
Branch: 4.0
commit 608e9673999593f6c107570c7cd1df6d55e20c3a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:44:31 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Bug:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
bi...@google.com <bi...@google.com> #18
Branch: 8.0
commit 7b9dea5b4c29b5aa9dde2e4a7db4cb28b68c9caf
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:32 2023
Fix test after changing API level for rewriting of JDK-8272564
Bug:
Change-Id: I67552a7fb13657ac9b4fb706592754d74d1b0653
M src/test/java/com/android/tools/r8/desugar/jdk8272564/Jdk8272564Test.java
bi...@google.com <bi...@google.com> #19
Branch: 8.0
commit 2a7c539ec35668c77b0eacb27612d7a5d8a2d11a
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Mar 03 08:43:21 2023
Also apply the rewriting for JDK-8272564 up to Andorid R
Bug:
Change-Id: I240de7d301677668b9c13b3b49c7b7951e6434b6
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
ww...@gmail.com <ww...@gmail.com> #20
Backported to 8.0.33, 4.0.55 and 3.3.91 for AGP 8.0, 7.4 and 7.3 respectively. To use a specific R8 version merge the following into settings.gradle
or settings.gradle.kts
:
pluginManagement {
buildscript {
repositories {
mavenCentral()
maven {
url = uri("https://storage.googleapis.com/r8-releases/raw")
}
}
dependencies {
classpath("com.android.tools:r8:8.1.4-dev")
}
}
}
ww...@gmail.com <ww...@gmail.com> #21
ka...@gmail.com <ka...@gmail.com> #24
While I am building I receive:
"A build operation failed.
Failed to create service 'com.android.build.gradle.internal.profile.AnalyticsService_704aac9b-2502-42f4-80cd-cccdba9bb437'.
Failed to create service 'com.android.build.gradle.internal.profile.AnalyticsService_704aac9b-2502-42f4-80cd-cccdba9bb437'.
Could not create an instance of type com.android.build.gradle.internal.profile.AnalyticsService.
Cannot query the value of this property because it has no value available."
Details:
Android Studio version: Android Studio Electric Eel | 2022.1.1
OS: Windows 10
Java versions: Oracle OpenJDK 11.0.10, Azul Zulu version 13.0.10
And some more details below:
I would like to mention that my Android Studio project contains two projects on the same root as it is mentioned in the previous comments (multi-root project).
Here are some more tests I did:
Windows 10, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.4.0 => The problem as it is described above
Windows 10, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.3.1 => Build and run successfully
Windows 10, Android Studio Electric Eel | 2022.1.1, Gradle 7.4, AGP 7.3.1 => Build and run successfully
Mac OS Monterey 12.6.2, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.4.0 => The problem as it is described above
Mac OS Monterey 12.6.2, Android Studio Electric Eel | 2022.1.1, Gradle 7.5, AGP 7.3.1 => Build and run successfully
Mac OS Monterey 12.6.2, Android Studio Dolphin | 2021.3.1, Gradle 7.5, AGP 7.4.0 => The problem as it is described above
Mac OS Monterey 12.6.2, Android Studio Dolphin | 2021.3.1, Gradle 7.5, AGP 7.3.1 => Could not run due to the reason that AGP 7.3.1 requires as minimum the Gradle 7.4
As I can understand, the problem is on the AGP 7.4.0 which tries to create the AnalyticsSettings instance.
As a current solution to my problem, I am using Gradle 7.5 with AGP 7.3.1 in the latest Android Studio versions(Dolphin and Electric) for my project.
Regards,
ga...@linecorp.com <ga...@linecorp.com> #25
Fixed with I905dd70a2e7ccf05b3a7da1c83e2af4260b71ece and the fix will be available since 8.0-alpha01.
Is it possible to backport this change on stable version(AGP 7.4)?
pa...@gmail.com <pa...@gmail.com> #26
@ww... in #20
> I couldn't add exact code you've provided because of the error Unresolved reference: setOptedIn.
This happens when the class is not on the right classpath.
It's housed in com.android.tools.analytics-library:shared:30.4.0.
Which is a transitive dependency of com.android.tools:sdk-common:30.4.0.
In one of the AGP 7.x versions a lot of dependencies (including sdk-common) have been moved from compile to runtime scope in the POM, so they moved from compileClasspath to runtimeClasspath configuration in Gradle.
So, in Kotlin we need the class be present and compileClasspath, Groovy doesn't care as it's interpreted and does exactly the reflective code you posted.
I couldn't make it work with this hack, tried many-many ways, but only synced by editing analytics.settings.
dm...@mapbox.com <dm...@mapbox.com> #27
The only workaround that worked was to disable `Send usage statistics to google` in settings, changing flag manually in `~./android/analytics.settings` had no effect and AS kept overwriting the file.
pa...@gmail.com <pa...@gmail.com> #28
Edit the file and make it read-only. It will warn on every AGP build, and on AS startup you'll get a weird opt-in dialog, but AS won't be able to change it back.
fu...@gmail.com <fu...@gmail.com> #29
Fixed with I905dd70a2e7ccf05b3a7da1c83e2af4260b71ece and the fix will be available since 8.0-alpha01.
Is it possible to backport this change on stable version(AGP 7.4) or gradle(7.5+)?
bi...@google.com <bi...@google.com> #30
Unfortunately, it is not an option
da...@gmail.com <da...@gmail.com> #31
Please advise if possible on a solution. Thank you in advance.
[Deleted User] <[Deleted User]> #32
// id "com.android.application"
// id "kotlin-android"
// id "dev.flutter.flutter-gradle-plugin"
//}
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
localPropertiesFile.withReader('UTF-8') { reader ->
localProperties.load(reader)
}
}
def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
flutterVersionCode = '1'
}
def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
flutterVersionName = '1.0'
}
apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply plugin: 'com.google.gms.google-services'
//apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
android {
namespace "com.example.notification_fiebase"
compileSdkVersion 33
ndkVersion flutter.ndkVersion
compileOptions {
coreLibraryDesugaringEnabled true
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
kotlinOptions {
jvmTarget = '1.8'
}
sourceSets {
main.java.srcDirs += 'src/main/kotlin'
}
defaultConfig {
multiDexEndabled true
// TODO: Specify your own unique Application ID (
applicationId "com.example.notification_fiebase"
// You can update the following values to match your application needs.
// For more information, see:
minSdkVersion 19
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
}
buildTypes {
release {
// TODO: Add your own signing config for the release build.
// Signing with the debug keys for now, so `flutter run --release` works.
signingConfig signingConfigs.debug
}
}
}
flutter {
source '../..'
}
dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
implementation "com.google.firebase:firebase-bom:32.7.1"
}
'flutter' for extension 'android' of type com.android.build.gradle.internal.dsl.BaseAppModuleExtension.
solve that issue
Description
DESCRIBE THE ISSUE IN DETAIL:
While Gradle 7.2 works fine, and Gradle 7.4 works fine in AS 2021.1.1, Gradle 7.4 fails in AS 2021.3.1 Canary 7 with the following exception:
STEPS TO REPRODUCE:
ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE
ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)
Build: AI-213.6777.52.2113.8305692, 202203160046,
AI-213.6777.52.2113.8305692, JRE 11.0.13+0-b1751.21-8125866x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.3, screens 3456.0x2234.0, 5120.0x2880.0; Retina
AS: Dolphin | 2021.3.1 Canary 7; Kotlin plugin: 213-1.6.20-M1-release-for-android-studio-AS6777.52; Android Gradle Plugin: 7.1.2; Gradle: 7.4; Gradle JDK: version 11.0.13; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: 3.22.0