Optimize manifest merging for apps and library [234170605]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

xa...@google.com

created issue #1

May 27, 2022 09:12PM

Using a basic project with 1 app and 1 lib, using AGP 7.4.0 alpha 2, we see the following manifest files after a build:

$ find . -name AndroidManifest.xml
./app/build/intermediates/merged_manifest/debug/AndroidManifest.xml
./app/build/intermediates/merged_manifests/debug/AndroidManifest.xml
./app/build/intermediates/packaged_manifests/debug/AndroidManifest.xml
./app/src/main/AndroidManifest.xml
./mylibrary/build/intermediates/merged_manifest/debug/AndroidManifest.xml
./mylibrary/build/intermediates/aapt_friendly_merged_manifests/debug/aapt/AndroidManifest.xml
./mylibrary/src/main/AndroidManifest.xml

The fact that we have 3 intermediate manifests in the app and (more importantly) 2 in the library is probably something we can optimize, in some cases.

The most important aspect here is the library as we need this for scaling. If the reason to have 2 is something we can put behind an opt-in feature that would be better.

Comments

je...@google.com <je...@google.com> Sep 19, 2022 04:56PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #2Sep 22, 2022 10:18PM

I have not seen any information about it so just asking here to avoid opening another issue. It also seems that when generating APK with alpha 8 the dex is no more compressed in the APK and stored as is. Leading to way bigger APKs.

While this is not an issue when distributing via Play Store, this could have impact for all the other distribution channels. Is this a normal wanted change and we'll have to deal with it? Or is there some new parameter to control this?

al...@google.com <al...@google.com> Oct 10, 2022 07:50PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #3Oct 18, 2022 06:39PM

I can reproduce the originally reported issue of missing Baseline Profiles with AGP 8.0.0-alpha08. To verify, check out the bw/agp8 branch of the samples, create and inspect release builds.

Message last modified on Oct 18, 2022 06:40PM

al...@google.com <al...@google.com> Oct 19, 2022 07:26PM

Marked as fixed.

xa...@google.com <xa...@google.com> #4Oct 19, 2022 10:04PM

AS for comment#2, I recommend creating a new issue.

sa...@google.com <sa...@google.com> #5Nov 2, 2022 05:32PM

Created https://issuetracker.google.com/issues/259832799 can't triage to proper component.

sa...@google.com <sa...@google.com> #6Nov 3, 2022 01:42PM

the location of the baseline profile has changed, it is now in dexopt folder instead of com.android.tools.build.profiles

please file a different bug for other issues so we can assign them correctly for each issue.