Status Update
Comments
a1...@gmail.com <a1...@gmail.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ml...@google.com <ml...@google.com>
a1...@gmail.com <a1...@gmail.com> #3
a1...@gmail.com <a1...@gmail.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
co...@sim.org <co...@sim.org> #5
For those coming after, you get to this setting when you start up the emulator, even though it's not starting up normally, click on the three dots on the toolbar to the side of the emulator window, click Settings, then on the right side you'll see Advanced at the top. That's where to choose autoselect as in above screenshot.
bo...@google.com <bo...@google.com>
ya...@google.com <ya...@google.com> #6
Also, cannot repro the issue with any gpu settings. If anyone could repro it, please run the emulator from command line:
/path/to/emulator -avd [your_avd_name] -feature GLESDynamicVersion -verbose
and upload the logs here. I will close the issue for now, and will reopen if there would be more reports or logs.
a1...@gmail.com <a1...@gmail.com> #7
I have attached the output from ~/Files/Android/sdk/emulator/emulator -avd Pixel_4a_API_33 -feature GLESDynamicVersion -verbose 2>&1
mr...@gmail.com <mr...@gmail.com>
ya...@google.com <ya...@google.com> #8
Hi,
please try to update to the latest emulator (33.1.6+), thanks!
a1...@gmail.com <a1...@gmail.com> #9
Launching a Pixel 4a AVD using API 33.
surfaceflinger (inside the AVD) still crashes if I set the renderer to "Desktop native OpenGL" and API level to "Compatibility".
Everything still works just fine if I set both settings to auto.
So, no change from 2 Feb, when I last reported that setting both things to auto fixed this.
ap...@rtwsa.com <ap...@rtwsa.com> #10
ya...@google.com <ya...@google.com>
ya...@google.com <ya...@google.com> #11
Hi,
If you got the chance, would you help to run the emulator again with -feature GLESDynamicVersion -verbose
, then send us both the emulator console output and logcat?
We are looking for the OpenGL ES version there, we want them to have GLES version number >=3.0 (Mac OpenGL core profile 4.1).
The logs in #7 and #2 have different version numbers. So we want to check if logcat gets the right version after using -feature GLESDynamicVersion
.
a1...@gmail.com <a1...@gmail.com> #12
Launching a Pixel 4a AVD using API 33 (revision 12).
I tried all combinations of Desktop/Swiftshader + Compatibility/Max. Only Desktop + Compatibility results in surfaceflinger crashing. I included the other logs as well in case they prove useful.
I noticed on the crashing one that surface flinger crashed just after the line "SurfaceFlinger: Enter boot animation" in logcat so I trimmed the other logcats shortly after that line (since they were otherwise over 2.5M).
Hopefully something in there helps...
ya...@google.com <ya...@google.com> #13
Thank you for your logs. That is extremely helpful. The logs showed that we sent a wrong GLES version number to the guest. I can narrow down the root cause now.
ya...@google.com <ya...@google.com> #14
Hi Devki,
please help to cp aosp/2620446 to next stable. Thanks!
de...@google.com <de...@google.com>
vk...@google.com <vk...@google.com> #15
de...@google.com <de...@google.com>
um...@gmail.com <um...@gmail.com> #16
Android Emulator / Virtual Device not working on M1 - 8GB(Unfortunately, your computer does not support hardware accelerated virtualization). Is the issue resolved to run android virtual device on M1 Mac- Ventura-V-13.2
ya...@google.com <ya...@google.com> #17
it looks like a different bug. Would you file a new issue with all the emulator console output attached? Thanks
Description
STEPS TO REPRODUCE:
1. Setup an AVD with API >30, arm64-v8a (Google APIs). In my case, I used Pixel 4a as the device (since that's what I have).
2. Start the emulator
API 30 works.
API 28 also works.
I assumed this was a temporary issue with API 31... but the issue persists with API 32 which makes testing things difficult without using my actual phone.
ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE
There's nothing to see, just the "Google" splash screen.
ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)
Emulator bug report thing doesn't work (because the system hasn't come up?), but I captured a logcat showing something crashing over and over again.
Android Studio Chipmunk | 2021.2.1 Patch 2
Build #AI-212.5712.43.2112.8815526, built on July 11, 2022
Runtime version: 11.0.12+0-b1504.28-7817840 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.5.1
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: org.jetbrains.kotlin (212-1.7.10-release-333-AS5457.46)
Android Emulator 31.3.10 (installed by Android Studio)
MacBook Pro (14-inch, 2021)
macOS Monterey 12.5.1
M1 Pro CPU
16GB RAM