r8.jvmArgs don't get used [258704137]

Fixed

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Nov 10, 2022 09:10PM

In b/258677934 I found that I could specify r8.runInSeparateProcess by adding this to settings.gradle :

buildscript {
    dependencies {
        classpath "com.android.tools.build:gradle-settings:8.0.0-alpha05"
    }
}

apply(plugin: "com.android.settings")

android {
    execution {
        profiles {
            Jeff {
                r8 {
                    runInSeparateProcess true
                }
            }
        }
        defaultProfile "Jeff"
    }
}

However, when I try to set jvmArgs in the same way, it doesn't have an effect:

android {
    execution {
        profiles {
            Jeff {
                r8 {
                    runInSeparateProcess true
                    setJvmOptions(["-Xms2g", "-Xmx2g"])
                }
            }
        }
        defaultProfile "Jeff"
    }
}

This appears to be because

https://android.googlesource.com/platform/tools/base/+/08c2b7273892834207e8fcc302a89b29eb88d69b/build-system/gradle-core/src/main/java/com/android/build/gradle/internal/tasks/R8Task.kt#587

says

forkOptions.jvmArgs?.addAll(executionOptions.get().jvmArgs)

rather than

forkOptions.jvmArgs(executionOptions.get().jvmArgs)

Comments

je...@google.com <je...@google.com> #2Nov 10, 2022 10:02PM

I have not seen any information about it so just asking here to avoid opening another issue. It also seems that when generating APK with alpha 8 the dex is no more compressed in the APK and stored as is. Leading to way bigger APKs.

While this is not an issue when distributing via Play Store, this could have impact for all the other distribution channels. Is this a normal wanted change and we'll have to deal with it? Or is there some new parameter to control this?

ga...@google.com <ga...@google.com> Nov 11, 2022 09:44AM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #3Nov 17, 2022 10:37PM

I can reproduce the originally reported issue of missing Baseline Profiles with AGP 8.0.0-alpha08. To verify, check out the bw/agp8 branch of the samples, create and inspect release builds.

Message last modified on Nov 17, 2022 10:37PM

je...@google.com <je...@google.com> #4Nov 17, 2022 10:40PM

AS for comment#2, I recommend creating a new issue.

je...@google.com <je...@google.com> #5Nov 17, 2022 10:49PM

Created https://issuetracker.google.com/issues/259832799 can't triage to proper component.

je...@google.com <je...@google.com> #6Nov 18, 2022 11:14PM

Marked as fixed.

the location of the baseline profile has changed, it is now in dexopt folder instead of com.android.tools.build.profiles

please file a different bug for other issues so we can assign them correctly for each issue.

sp...@google.com <sp...@google.com> #7Nov 19, 2022 06:26AM

There is no dexopt or any baseline profile related file in the generated aab. There is also nothing related to baseline profile in APK generated with AGP 8.0.

Can you please verify, keep the issue opened and provide a solution?

72...@gmail.com <72...@gmail.com> #8Jan 26, 2023 05:16PM

As a side note I do use:

android.experimental.enableNewResourceShrinker.preciseShrinking=true

And

<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:tools="http://schemas.android.com/tools"
    tools:shrinkMode="strict" />

So maybe depending on when the baseline is packaged it's removed, but in all case it's not working currently so not really WAI.