TypedArray#close (API 31) not desugared but AS does not display warning when used in try-with-resources [262851206]

Fixed

Bug

Status Update

No update yet.

Description

pu...@gmail.com

created issue #1

Dec 17, 2022 01:43PM

Using: AS 2022.2.1 Canary 9, com.android.tools:desugar_jdk_libs:2.0.0, AGP 8.0.0-alpha09

Code below does not cause AS to show any warning that it is API 31+ only when TypedArray#close is invoked as part of a try-with-resources block:

	try (TypedArray array = ...) {
        {
        } // TypedArray#close implicitly called, crash on API < 31

In fact, an IDE intention suggested that I converted my classic use to TypedArray (that is, calling TypedArray#release after use) to a try-with-resources block, which I did (since I saw no API warning I assumed it was either desugared or properly handled for all API levels by D8) only to see it crash on API < 31.

It would be nice to have this call desugared or AS not suggesting to use try-with-resources on minApiSdk < 31 (which is probably pretty much all apps currently).

Comments

pu...@gmail.com <pu...@gmail.com> #2Dec 17, 2022 01:46PM

I have not seen any information about it so just asking here to avoid opening another issue. It also seems that when generating APK with alpha 8 the dex is no more compressed in the APK and stored as is. Leading to way bigger APKs.

While this is not an issue when distributing via Play Store, this could have impact for all the other distribution channels. Is this a normal wanted change and we'll have to deal with it? Or is there some new parameter to control this?

ze...@google.com <ze...@google.com> Dec 19, 2022 08:11AM

Reassigned to cl...@google.com.

sg...@google.com <sg...@google.com> #3Dec 19, 2022 09:36AM

Reassigned to an...@google.com.

I can reproduce the originally reported issue of missing Baseline Profiles with AGP 8.0.0-alpha08. To verify, check out the bw/agp8 branch of the samples, create and inspect release builds.

tn...@google.com <tn...@google.com> Dec 22, 2022 05:50PM

Reassigned to tn...@google.com.

sg...@google.com <sg...@google.com> #4Jan 4, 2023 02:13PM

AS for comment#2, I recommend creating a new issue.

tn...@google.com <tn...@google.com> #5Jan 4, 2023 03:52PM

Marked as fixed.

Created https://issuetracker.google.com/issues/259832799 can't triage to proper component.

sg...@google.com <sg...@google.com> #6Jan 4, 2023 04:05PM

the location of the baseline profile has changed, it is now in dexopt folder instead of com.android.tools.build.profiles

please file a different bug for other issues so we can assign them correctly for each issue.

sa...@google.com <sa...@google.com> #7Jan 17, 2023 08:26PM

There is no dexopt or any baseline profile related file in the generated aab. There is also nothing related to baseline profile in APK generated with AGP 8.0.

Can you please verify, keep the issue opened and provide a solution?