IssueTracker

Respectfully in regards to marking this duplicate. It is not quite a duplicate. That referenced ticket is part of SafeArgs, while this request is for typesafe navigation. It was marked as "infeasible", yet w'ere talking about two completely different bases.

In the last comment:

This requires support for doubles in NavInflater whose values are all backed by the TypedValue class, which unfortunately does not support Double values so we cannot go forward with this.

When in fact this is trivial to implement in compose typesafe navigation and seems to be a major omission:

object DoubleNavType : NavType<Double>(isNullableAllowed = false) {
    @Suppress("DEPRECATION")
    override fun get(bundle: Bundle, key: String): Double = bundle[key] as Double

    override fun parseValue(value: String): Double {
        // At runtime the d suffix is optional, contrary to the Safe Args plugin.
        // This is in order to be able to parse double numbers passed as deep link URL
        // parameters
        var localValue = value
        if (value.endsWith("d")) {
            localValue = localValue.substring(0, value.length - 1)
        }
        return localValue.toDouble()
    }

    override fun put(bundle: Bundle, key: String, value: Double) {
        bundle.putDouble(key, value)
    }
}

/**
 * Convience class to allow for double navigation types by turning them into strings and back.
 */
object NullableDoubleNavType : NavType<Double?>(isNullableAllowed = true) {
    @Suppress("DEPRECATION")
    override fun get(bundle: Bundle, key: String): Double? = bundle[key] as? Double?

    override fun parseValue(value: String): Double? {
        if (value == "null") return null
        return DoubleNavType.parseValue(value)
    }

    override fun put(bundle: Bundle, key: String, value: Double?) {
        if (value == null) {
            bundle.putSerializable(key, null)
        } else {
            DoubleNavType.put(bundle, key, value)
        }
    }
}

// in a route 
typeOf<Double>() to DoubleNavType,
typeOf<Double?>() to NullableDoubleNavType,

Similar to the work done in b/351994237 to expand the types supported by Navigation Compose Safe Args to support anything @Serializable can support, I think we can do something similar here to support doubles.

sad674274@gmail.com

DoubleArray support added in https://android-review.googlesource.com/c/platform/frameworks/support/+/3266717

Fixed internally and will be available in navigation 2.8.2.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.annotation:annotation-wasm-js:1.9.0-rc01
• androidx.annotation:annotation-watchosdevicearm64:1.9.0-rc01
• androidx.navigation:navigation-common:2.8.2
• androidx.navigation:navigation-runtime:2.8.2

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.navigation:navigation-common:2.9.0-alpha01

Yep same one:

 D  Current entry being composed in AnimatedContent screen1
 D  Outside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 D  Inside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 I  Skipped 40 frames!  The application may be doing too much work on its main thread.
 D  Installing profile for com.andreirozov.sample
 D  Current entry being composed in AnimatedContent screen1
 D  Outside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 D  Inside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 D  Current entry being composed in AnimatedContent screen1
 D  Outside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 D  Inside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 D  navigating to screen2
 D  Current entry being composed in AnimatedContent screen1
 D  Current entry being composed in AnimatedContent screen2
 E  screen2 entry state outside Scaffold is STARTED
 D  Outside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen2
 E  screen2 entry state in Scaffold STARTED
 D  Current entry being composed in AnimatedContent screen2
 E  screen2 entry state outside Scaffold is STARTED
 D  Outside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 D  Inside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 D  Current entry being composed in AnimatedContent screen2
 E  screen2 entry state outside Scaffold is RESUMED
 D  Outside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 D  Inside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 E  screen2 entry state in Scaffold RESUMED
 D  Current entry being composed in AnimatedContent screen2
 E  screen2 entry state outside Scaffold is RESUMED
 D  Outside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 D  Inside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 D  Current entry being composed in AnimatedContent screen2
 E  screen2 entry state outside Scaffold is RESUMED
 D  Outside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 D  Inside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen2
 E  screen2 entry state in Scaffold RESUMED
 D  navigating to screen1
 D  Current entry being composed in AnimatedContent screen2
 E  screen2 entry state outside Scaffold is CREATED
 D  Current entry being composed in AnimatedContent screen1
 D  Outside of conditional
 D  transition currentState: screen2
 D  transition targetState: screen1
 I  Background young concurrent copying GC freed 53694(1896KB) AllocSpace objects, 0(0B) LOS objects, 25% free, 4767KB/6441KB, paused 7.336ms total 70.605ms
 D  Current entry being composed in AnimatedContent screen1
 D  Outside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 D  Inside of conditional
 D  transition currentState: screen1
 D  transition targetState: screen1
 E  screen2 entry state in Scaffold DESTROYED
 E  FATAL EXCEPTION: main
    Process: com.andreirozov.sample, PID: 2772
    java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
    	at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:202)
    	at androidx.lifecycle.viewmodel.compose.ViewModelKt.get(ViewModel.kt:206)
    	at androidx.lifecycle.viewmodel.compose.ViewModelKt.get$default(ViewModel.kt:195)
    	at androidx.lifecycle.viewmodel.compose.ViewModelKt.viewModel(ViewModel.kt:120)
    	at com.andreirozov.sample.ui.standings.screen2.Screen2TabKt.AnotherScreen(Screen2Tab.kt:84)
    	at com.andreirozov.sample.ui.AppNavGraphKt$AppNavGraph$5$1$1$2.invoke(AppNavGraph.kt:94)
    	at com.andreirozov.sample.ui.AppNavGraphKt$AppNavGraph$5$1$1$2.invoke(AppNavGraph.kt:89)
    	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
    	at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:127)
    	at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:127)
    	at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:162)
    	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2435)
    	at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2703)
    	at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3326)
    	at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3304)
    	at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
    	at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
    	at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3304)
    	at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3269)
    	at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:771)
    	at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:1047)
    	at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:124)
    	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:541)
    	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:510)
    	at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
    	at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
    	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
    	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
    	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:964)
    	at android.view.Choreographer.doCallbacks(Choreographer.java:790)
    	at android.view.Choreographer.doFrame(Choreographer.java:721)
    	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
    	at android.os.Handler.handleCallback(Handler.java:883)
    	at android.os.Handler.dispatchMessage(Handler.java:100)
    	at android.os.Looper.loop(Looper.java:214)
    	at android.app.ActivityThread.main(ActivityThread.java:7356)
    	at java.lang.reflect.Method.invoke(Native Method)
    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@7ebb51b, androidx.compose.ui.platform.MotionDurationScaleImpl@e6c86b8, StandaloneCoroutine{Cancelling}@f919c91, AndroidUiDispatcher@7da07f6]
 I  Sending signal. PID: 2772 SIG: 9

Thanks Jeremy.

The logging in #12 also confirms Scaffold's behavior of recomposing after being removed from composition. Marking this a dup of b/254645321

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.navigation:navigation-compose:2.8.0-alpha01

Hello, these changes in fact introduced in 2.7.1 are creating issues in our architecture. Basically we are no longer able to receive Lifecycle.Event.ON_DESTROY as it is now triggered after onDispose where we are unsubscribing a lifecycle observer. (Sample attached)

fun attachLifeCycleObserver(onDestroy:() -> Unit) {

    val lifecycle = LocalLifecycleOwner.current.lifecycle
    DisposableEffect(lifecycle) {
        val eventObserver = LifecycleEventObserver { source, event ->
            println("PACMAC -- event:${event.name}  targetState:${event.targetState.name} source:${source.toString()}")
            if (event == Lifecycle.Event.ON_DESTROY) {
                onDestroy()
            }
        }
        
        lifecycle.addObserver(eventObserver)
        onDispose {
            // We unsubscribe here but since 2.7.1 we are no longer receiving ON_DESTROY as it is actually triggered after onDispose
            lifecycle.removeObserver(eventObserver)
        }
    }
}

We are using onDestroy to run some cleanup but only if the nav destination is popped of the backstack.