IllegalArgumentException in android.graphics.RuntimeShader [283693347]

Assigned

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 22, 2023 09:24AM

java.lang.IllegalArgumentException happened in android.graphics.RuntimeShader:

android-12.0.0_r28

FATAL EXCEPTION: main
Process: com.android.systemui, PID: 1105
java.lang.IllegalArgumentException: error: 13: expected ';', but found '
at android.graphics.RuntimeShader.nativeCreateBuilder(Native Method)
at android.graphics.RuntimeShader.<init>(RuntimeShader.java:53)
at android.graphics.drawable.RippleShader.<init>(RippleShader.java:130)
at android.graphics.drawable.RippleDrawable.createAnimationProperties(RippleDrawable.java:970)
at android.graphics.drawable.RippleDrawable.drawPatterned(RippleDrawable.java:900)
at android.graphics.drawable.RippleDrawable.draw(RippleDrawable.java:804)
at android.graphics.drawable.DrawableContainer.draw(DrawableContainer.java:87)
at android.view.View.getDrawableRenderNode(View.java:22934)
at android.view.View.drawBackground(View.java:22863)
at android.view.View.draw(View.java:22637)
at android.view.View.updateDisplayListIfDirty(View.java:21520)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21476)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21476)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21476)
at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:534)
at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:540)
at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:616)
at android.view.ViewRootImpl.draw(ViewRootImpl.java:4438)
at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4166)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3326)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2143)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8665)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
at android.view.Choreographer.doCallbacks(Choreographer.java:845)
at android.view.Choreographer.doFrame(Choreographer.java:780)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7839)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Comments

ra...@google.com <ra...@google.com> May 22, 2023 10:56AM

Assigned to an...@google.com.

rn...@google.com <rn...@google.com> #2May 24, 2023 06:28PM

Reassigned to du...@google.com.

Just a heads up that this is still a problem. Are you open to accept external PRs to solve this?

du...@google.com <du...@google.com> #3May 24, 2023 09:21PM

To add to this, with AGP 7.1.x things got even worse as now there are several configureNdk* tasks, one for each ABI. Like: configureNdkBuildDebug[x86_64].

All those tasks (both the NDK and the CMake ones) are not plugged correctly in the task graph and they’re not depending on preBuild, preDebugBuild, and so on.

We have to manually add those dependencies in our build.gradle which feels extremely hacky.

I saw that the issues got unassigned on the issue tracker, so I’m asking what should we do to get more visibility.

[Deleted User] <[Deleted User]> #4May 25, 2023 08:17AM

Jerome for re-assigning this to someone.

bugreport-evolution_headunit-EVOLUTION_HEADUNIT_SOAA_100_0_15-2023-04-09-18-28-09.zip

31 MB

Download

du...@google.com <du...@google.com> #5May 25, 2023 08:44AM

Reassigned to sc...@google.com.

@corti.nico regarding comment#13, do you need per-ABI preBuild hooks like preDebugBuild[x86_64] before you're unblocked?

sc...@google.com <sc...@google.com> #6May 25, 2023 02:09PM

Reassigned to Deleted User.

regarding comment#13, do you need per-ABI preBuild hooks like preDebugBuild[x86_64] before you're unblocked?

Thanks for the follow up.

I'd say that depending on preBuild would be the minimum requirement, as those tasks have no dependencies at all at the moment.

If you could properly let them depend on the build-variant preBuild tasks (i.e. preDebugBuild), would be great.

per-ABI hooks feel unnecessary to me.

br...@google.com <br...@google.com> #7May 25, 2023 02:37PM

This seems fixed for me btw in 7.3.0-alpha09 including:

Tasks: clean and assembleDebug
ABIs: All 4 default and single ones like x86_64
OS: MacOS 12.3-12.4Beta2 (local dev) and Ubuntu 20.04.4 (CI Flow with GitHub Actions)
Version of Java: Temurin 11, Temurin 18, OpenJDK 18 locally, etc
Version of Gradle: 7.3.3, 7.5 nightly (20220331233901)
Version of SDK Build Tools: 31.0.0
Version of NDK: 24.0.8215888, 25.0.8221429 rc2

Looking solid, lemme kno if worth identifying the AGP version and/or commit that fixed it.

Full details including repro and logs

[Deleted User] <[Deleted User]> #8Jan 22, 2024 09:06AM

Here is the link to the fix https://android.googlesource.com/platform/tools/base/+/00e15bcb18d58470ce702c415e5db73ce29d1da6 7.3.0-alpha09 sounds right.