[Compose] Occurs Exception "You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed." when pass the custom arguments in nested graph. [289971980]

Duplicate

of 268422136

Bug

Status Update

No update yet.

Description

si...@sentbe.com

created issue #1

Jul 5, 2023 09:57AM

Component used: Navigation

Version used: 2.5.3

Devices/Android versions reproduced on: Pixel 3a API 33

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue. A screenrecord or screenshots showing the issue (if UI related). I used jetpack compose navigation for nested graph. here my project structure. If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

I used jetpack compose navigation for nested graph. here my project structure.

// top level navHost

@Composable
fun TopNavHost(
    appState: AppState,
    modifier: Modifier = Modifier,
) {
    val navController = appState.navController
    val activity = LocalContext.current as FragmentActivity

       // navigate!
        homeGraph(
            // •••
        )
}

fun NavGraphBuilder.homeGraph(
            // •••
) {
    // navigate !
    navigation(route = homeGraph, startDestination = homeRoute) {
        composable(
            route = homeRoute
        ) {
            HomeScreen(
             // •••
            )
        }

    }
}

new screen with bottom navigation bar

@Composable
fun HomeScreen(
    homeAppState: HomeAppState = rememberHomeAppState(),
) {
    val currentDestination = homeAppState.currentDestination
    val homeLevelTaps = homeAppState.homeLevelTabs

    Scaffold(
// if remove bottom bar, normal operation
        bottomBar = {
            if (currentDestination.shouldShowBottomBar(homeLevelTaps)) {
                BottomBar(
                    homeAppState = homeAppState,
                    navController = homeAppState.navController,
                )
            }
        }
    ) {
        // nested graph!!!
        HomeNavHost(
            modifier = Modifier.padding(
                bottom = if (currentDestination.shouldShowBottomBar(homeLevelTaps)) it.calculateBottomPadding() else 0.dp
            ),
            homeAppState = homeAppState,
        )
    }
}

A,B,C Screen in tempGraph

@Composable
fun HomeNavHost(
    modifier: Modifier = Modifier,
    homeAppState: HomeAppState,
    navController: NavHostController = homeAppState.navController,
            // •••
) {
    NavHost(
        navController = navController,
        route = homeGraph,
        startDestination = AGraph,
        modifier = modifier,
    ) {
        tempGraph(
            navToA = {
                navController.navigate(cRoute.asNavArg(it)) // with passed object
            },
            navToB = { navController.navigate(bRoute) },
            onBackPressed = {
                navController.navigateUp()
            }
        )

        temp2Graph()
        temp3Graph()
}

Presumably error source !!

fun NavGraphBuilder.tempGraph(
    navToC: (cArgs) -> Unit,
    navToB: () -> Unit,
    onBackPressed: () -> Unit,
) {
    navigation(
        route = tempGraph,
        startDestination = aRoute,
    ) {
        composable(
            route = aRoute,
        ) {
            ARoute(
                navToB = navToB
            )
        }

        composable(
            route = bRoute,
        ) {
            BRoute(
                navToB = navToB,
                onBackPressed = onBackPressed
            )
        }

        composable(
            route = cRoute,
            arguments = listOf(
                navArgument(NavArgKey) { // here !!! 
                    type = createNavType<cArgs>(isNullableAllowed = false)
                }
            )
        ) {
            CRoute(
                //argument = requireNotNull(it.arguments?.getNavArg()),
                onBackPressed = onBackPressed
            )
        }
    }
}

!!! The funny thing is that it works just fine for normal types. (only custom type) !!!

Exception Log

FATAL EXCEPTION: main
                 Process: com.test, PID: 3791
                 java.lang.IllegalStateException: You cannot access the NavBackStackEntry's ViewModels after the NavBackStackEntry is destroyed.
                 	at androidx.navigation.NavBackStackEntry.getViewModelStore(NavBackStackEntry.kt:213)
                 	at androidx.lifecycle.viewmodel.compose.ViewModelKt.get(ViewModel.kt:208)
                 	at androidx.lifecycle.viewmodel.compose.ViewModelKt.viewModel(ViewModel.kt:156)
                 	at androidx.navigation.compose.NavBackStackEntryProviderKt.SaveableStateProvider(NavBackStackEntryProvider.kt:98)
                 	at androidx.navigation.compose.NavBackStackEntryProviderKt.access$SaveableStateProvider(NavBackStackEntryProvider.kt:1)
                 	at androidx.navigation.compose.NavBackStackEntryProviderKt$LocalOwnersProvider$1.invoke(NavBackStackEntryProvider.kt:52)
                 	at androidx.navigation.compose.NavBackStackEntryProviderKt$LocalOwnersProvider$1.invoke(NavBackStackEntryProvider.kt:51)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
                 	at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228)
                 	at androidx.navigation.compose.NavBackStackEntryProviderKt.LocalOwnersProvider(NavBackStackEntryProvider.kt:47)
                 	at androidx.navigation.compose.NavHostKt$NavHost$4.invoke(NavHost.kt:162)
                 	at androidx.navigation.compose.NavHostKt$NavHost$4.invoke(NavHost.kt:141)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:117)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:129)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.jvm.kt:128)
                 	at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:169)
                 	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2469)
                 	at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2761)
                 	at androidx.compose.animation.CrossfadeKt$Crossfade$5$1.invoke(Crossfade.kt:134)
                 	at androidx.compose.animation.CrossfadeKt$Crossfade$5$1.invoke(Crossfade.kt:128)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
                 	at androidx.compose.animation.CrossfadeKt.Crossfade(Crossfade.kt:142)
                 	at androidx.compose.animation.CrossfadeKt.Crossfade(Crossfade.kt:73)
                 	at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:141)
                 	at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:67)
                 	at com.test.home.navigation.HomeNavHostKt.HomeNavHost(HomeNavHost.kt:33)
                 	at com.test.home.HomeScreenKt$HomeScreen$2.invoke(HomeScreen.kt:51)
                 	at com.test.home.HomeScreenKt$HomeScreen$2.invoke(HomeScreen.kt:50)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:117)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
                 	at androidx.compose.material3.ScaffoldKt$ScaffoldLayout$1$1$1$bodyContentPlaceables$1.invoke(Scaffold.kt:239)
                 	at androidx.compose.material3.ScaffoldKt$ScaffoldLayout$1$1$1$bodyContentPlaceables$1.invoke(Scaffold.kt:221)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$subcompose$3$1$1.invoke(SubcomposeLayout.kt:1058)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$subcompose$3$1$1.invoke(SubcomposeLayout.kt:695)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108)
                 	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
                 	at androidx.compose.runtime.ActualJvm_jvmKt.invokeComposable(ActualJvm.jvm.kt:78)
03:23:28.276  E  	at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3342)
                 	at androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3274)
                 	at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:588)
                 	at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1004)
                 	at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:4005)
                 	at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcomposeInto(SubcomposeLayout.kt:715)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:688)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:679)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:663)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$Scope.subcompose(SubcomposeLayout.kt:1005)
                 	at androidx.compose.material3.ScaffoldKt$ScaffoldLayout$1$1$1.invoke(Scaffold.kt:221)
                 	at androidx.compose.material3.ScaffoldKt$ScaffoldLayout$1$1$1.invoke(Scaffold.kt:128)
                 	at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1$measure$1.placeChildren(SubcomposeLayout.kt:873)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildren$1$1.invoke(LayoutNodeLayoutDelegate.kt:321)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildren$1$1.invoke(LayoutNodeLayoutDelegate.kt:313)
                 	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2254)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:457)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutSnapshotReads$ui_release(OwnerSnapshotObserver.kt:77)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.layoutChildren(LayoutNodeLayoutDelegate.kt:313)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.onNodePlaced$ui_release(LayoutNodeLayoutDelegate.kt:447)
                 	at androidx.compose.ui.node.InnerNodeCoordinator.placeAt-f8xVGno(InnerNodeCoordinator.kt:140)
                 	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                 	at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:440)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:630)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:624)
                 	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2254)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:457)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:120)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutModifierSnapshotReads$ui_release(OwnerSnapshotObserver.kt:92)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-f8xVGno(LayoutNodeLayoutDelegate.kt:624)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.replace(LayoutNodeLayoutDelegate.kt:647)
                 	at androidx.compose.ui.node.LayoutNode.replace$ui_release(LayoutNode.kt:864)
                 	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:461)
03:23:28.276  E  	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded$default(MeasureAndLayoutDelegate.kt:433)
                 	at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:336)
                 	at androidx.compose.ui.platform.AndroidComposeView.onLayout(AndroidComposeView.android.kt:922)
                 	at android.view.View.layout(View.java:23693)
                 	at android.view.ViewGroup.layout(ViewGroup.java:6413)
                 	at androidx.compose.ui.platform.AbstractComposeView.internalOnLayout$ui_release(ComposeView.android.kt:322)
                 	at androidx.compose.ui.platform.AbstractComposeView.onLayout(ComposeView.android.kt:313)
                 	at android.view.View.layout(View.java:23693)
                 	at android.view.ViewGroup.layout(ViewGroup.java:6413)
                 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                 	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                 	at android.view.View.layout(View.java:23693)
                 	at android.view.ViewGroup.layout(ViewGroup.java:6413)
                 	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
                 	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
                 	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
                 	at android.view.View.layout(View.java:23693)
                 	at android.view.ViewGroup.layout(ViewGroup.java:6413)
                 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                 	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                 	at com.android.internal.policy.DecorView.onLayout(DecorView.java:799)
                 	at android.view.View.layout(View.java:23693)
                 	at android.view.ViewGroup.layout(ViewGroup.java:6413)
                 	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:3999)
                 	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3372)
                 	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2328)
                 	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9087)
                 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231)
                 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
                 	at android.view.Choreographer.doCallbacks(Choreographer.java:899)
                 	at android.view.Choreographer.doFrame(Choreographer.java:832)
                 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
                 	at android.os.Handler.handleCallback(Handler.java:942)
                 	at android.os.Handler.dispatchMessage(Handler.java:99)
                 	at android.os.Looper.loopOnce(Looper.java:201)
                 	at android.os.Looper.loop(Looper.java:288)
                 	at android.app.ActivityThread.main(ActivityThread.java:7872)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Comments

jb...@google.com <jb...@google.com> #2Jul 5, 2023 03:31PM

This actually has nothing to do with NavHostFragment, but is the behavior of NavController's setGraph().

When you call navController.setGraph(R.navigation.navigation_graph), it stores that ID and will restore that ID automatically.

If you were to instead use:

NavInflater navInflater = new NavInflater(this, navController.getNavigatorProvider());
navController.setGraph(navInflater.inflate(R.navigation.navigation_graph));

Then NavController would not restore the graph itself and the call to restoreState() you point out would only restore the back stack state, etc. but would wait for you to call setGraph again.

You're right that the inconsistency between the two setGraph methods is concerning. We'll take a look.

si...@sentbe.com <si...@sentbe.com> #3Jul 6, 2023 01:43AM

Turns out, we already had a tracking bug for this issue, will follow up on that other one.

jb...@google.com <jb...@google.com> #4Jul 6, 2023 02:43PM

Status: Duplicate of

268422136

Thank you for promptly replying to my report. You are right that the issue you've just mentioned is similar to mine. I shall continue observing the progress over there.

Issue 289971980

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Jul 5, 2023 03:31PM

si...@sentbe.com <si...@sentbe.com> #3Jul 6, 2023 01:43AM

jb...@google.com <jb...@google.com> #4Jul 6, 2023 02:43PM

Add comment

Issue metadata