In Progress
Status Update
Comments
aj...@google.com <aj...@google.com>
aj...@google.com <aj...@google.com>
ap...@google.com <ap...@google.com> #2
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
commit dee3dac52dbe463eb77c382915340d9435bea131
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Fri Apr 19 21:11:33 2024
Merge PATCHES.json into sys-devel/llvm
This combines every patch stack into the sys-devel/llvm, removing
duplicates. New patches are appended to the bottom of
sys-devel/llvm/files/PATCHES.json, regardless of their age and
application range.
BUG=b:333451930
TEST=Built LLVM-9999 with patches applied.
Change-Id: Ib3ebaedacaf46f28925addb77536773aab1c4373
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5474322
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
A sys-devel/llvm/files/671af65d003bb0e26d29ee63469f8ea7e65ecfee.patch
M sys-devel/llvm/files/PATCHES.json
A sys-devel/llvm/files/compiler-rt-un-unset-compiler_rt_build_crt.patch
A sys-devel/llvm/files/disable-querying-git-in-benchmarking-code.patch
A sys-devel/llvm/files/scudo-Add-baseline-Scudo-config-for-ChromeOS-v2.patch
https://chromium-review.googlesource.com/5474322
Branch: main
commit dee3dac52dbe463eb77c382915340d9435bea131
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Fri Apr 19 21:11:33 2024
Merge PATCHES.json into sys-devel/llvm
This combines every patch stack into the sys-devel/llvm, removing
duplicates. New patches are appended to the bottom of
sys-devel/llvm/files/PATCHES.json, regardless of their age and
application range.
BUG=b:333451930
TEST=Built LLVM-9999 with patches applied.
Change-Id: Ib3ebaedacaf46f28925addb77536773aab1c4373
Reviewed-on:
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
A sys-devel/llvm/files/671af65d003bb0e26d29ee63469f8ea7e65ecfee.patch
M sys-devel/llvm/files/PATCHES.json
A sys-devel/llvm/files/compiler-rt-un-unset-compiler_rt_build_crt.patch
A sys-devel/llvm/files/disable-querying-git-in-benchmarking-code.patch
A sys-devel/llvm/files/scudo-Add-baseline-Scudo-config-for-ChromeOS-v2.patch
aj...@google.com <aj...@google.com> #3
Similar but different bug is
Bugjuggler:
bu...@google.com <bu...@google.com> #4
Hi. I've received your bug and will wait for b/343568613 to be resolved and then assign to ajordanr@google.com and mark as obsolete.
ap...@google.com <ap...@google.com> #5
[Details redacted due to bug visibility]
Change-Id: I8eadf9e5a06539aefc708417668a3890e6be887d
https://chrome-internal-review.googlesource.com/7339490
Change-Id: I8eadf9e5a06539aefc708417668a3890e6be887d
Description
Having N different PATCHES.json files across N packages complicates LLVM maintenance, both conceptually, and if someone wants to
cros workon
multiple LLVM packages simultaneously.All of this could be simplified if all LLVM packages logically shared the same source tree.
Since all of our LLVM ebuilds have
9999
versions, this should be much easier to implement & maintain now than it used to be.