Status Update
Comments
cl...@google.com <cl...@google.com>
cl...@google.com <cl...@google.com> #2
Waiting for Kotlin update in androidx:
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Update RoomGradlePlugin KSP configuration to support KSP2
Expand for full commit details
Update RoomGradlePlugin KSP configuration to support KSP2
The plugin does per-variant / per-platform configuration by adding a CommandLineArgumentProvider to the KSP task, with KSP2 the task class is different and does not implement the KSP1 base class. This CL updates the plugin integration to find and also configure the KSP2 task.
KSP2 is also more strict with regards to AP options and disallows whitespaces in the key-value pairs. However it might be that a schema path might contain spaces, so the plugin and processor will now encode / decode spaces as URLs would to satisfy the format requirements.
Bug: 379159770
Test: Manually in sample project with KSP2 and Room
Change-Id: Iec3c435cbdfb994034500668f1ec602d5ebde3ce
Files:
- M
room/room-compiler/src/main/kotlin/androidx/room/processor/Context.kt
- M
room/room-gradle-plugin/src/main/java/androidx/room/gradle/RoomArgumentProvider.kt
- M
room/room-gradle-plugin/src/main/java/androidx/room/gradle/integration/AndroidPluginIntegration.kt
- M
room/room-gradle-plugin/src/main/java/androidx/room/gradle/integration/KotlinMultiplatformPluginIntegration.kt
- M
room/room-gradle-plugin/src/main/java/androidx/room/gradle/util/Utils.kt
Hash: baeb0389517c66be31be785be64157a2b32c1f15
Date: Wed Dec 04 21:31:47 2024
ap...@google.com <ap...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler:2.7.0-alpha13
androidx.room:room-gradle-plugin:2.7.0-alpha13
ap...@google.com <ap...@google.com> #5
Branch: 8.6
commit 3a640e6f0cde8ae89777c7545b7ce825284d3bfa
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:06:09 2024
Fix NPE rewriting with different catch handlers
Bug:
Change-Id: Ice030042828a5c53c273cd328a0d7b0021562a78
M src/main/java/com/android/tools/r8/ir/conversion/passes/ThrowCatchOptimizer.java
M src/test/java/com/android/tools/r8/regress/B354625682Test.java
ap...@google.com <ap...@google.com> #6
Branch: 8.6
commit 53314d002df5e98eb7824d37fe1a5780ccc80888
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:05:35 2024
Reproduction for NullPointerException in try/catch
Bug:
Change-Id: I96559816c8d64af246465ec0942eb3c8c2f4d7de
A src/test/java/com/android/tools/r8/regress/B354625682Test.java
ap...@google.com <ap...@google.com> #7
Branch: 8.6
commit 3ec73ce1dbb45b2b43148cb32753ef1e9fada74d
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:07:49 2024
Version 8.6.16
Bug:
Bug:
Bug:
Bug:
Change-Id: I9f2ad5022503a910fad4e649cf5df8dbbb616316
M src/main/java/com/android/tools/r8/Version.java
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #8
Branch: 8.5
commit d360da0f12e43c2e9798aaa1bdf3443cb7661e51
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:26:24 2024
Version 8.5.34
Bug:
Bug:
Bug:
Bug:
Change-Id: Ife8945c8f8ed416af360c78e5fc4267bba97b967
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #9
Branch: 8.5
commit aee149373e928636fadcbd904ac8f427f31b3ca4
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:25:22 2024
Fix NPE rewriting with different catch handlers
Bug:
Change-Id: Ice030042828a5c53c273cd328a0d7b0021562a78
M src/main/java/com/android/tools/r8/ir/conversion/passes/ThrowCatchOptimizer.java
M src/test/java/com/android/tools/r8/regress/B354625682Test.java
ap...@google.com <ap...@google.com> #10
Branch: 8.5
commit 52d58c57927396788d58e5be18eb534c58cdaff3
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:24:54 2024
Reproduction for NullPointerException in try/catch
Bug:
Change-Id: I96559816c8d64af246465ec0942eb3c8c2f4d7de
A src/test/java/com/android/tools/r8/regress/B354625682Test.java
an...@google.com <an...@google.com> #11
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Koala Feature Drop | 2024.1.2 RC 1
- Android Gradle Plugin 8.6.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
an...@google.com <an...@google.com> #12
The fixes for this issue are now also available in:
- Android Studio Koala | 2024.1.1 Patch 2
- Android Gradle Plugin 8.5.2
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Description
Versions
Description
When processing jar files to generate dex files using D8 and R8 respectively, the resulting dex files behave inconsistently during execution. The dex file generated by R8 crashes upon execution with the error "Exception in thread 'main' java.lang.NullPointerException," which should actually be caught. In contrast, the dex file generated by D8 executes normally. We suspect this is an issue with R8.
Step to Reproduce
Expected Result(d8 dex output)
Actual Result(r8 dex output)
Testcase Source Code
rules.pro