IllegalArgumentException when selecting an item after cancelled back gesture cross-fragment animation [358743378]

Duplicate

of 342419080

Bug

Status Update

No update yet.

Description

tr...@gmail.com

created issue #1

Aug 10, 2024 07:33PM

Components used: Fragment v1.8.2, Navigation v2.7.7

Devices/Android versions reproduced on: Android 14 and 15

The attached sample project works fine including the predictive back gesture animations on drawer closing and cross-fragment. However, it crashes when selecting an item from the drawer menu after a cross-fragment back gesture animation is canceled.

java.lang.IllegalArgumentException: saveBackStack("ebcca18f-eabb-424e-97b3-63de5fc97b85") must be self contained and not reference fragments from non-saved FragmentTransactions. Found reference to fragment FragmentOne{f7891b} (005b0355-e5f5-48d6-9ea8-df260bf6f4f4 id=0x7f080136 tag=1e300225-9207-4967-9e10-11f7bbd1ba65) in BackStackEntry{1ecf460 #4 ebcca18f-eabb-424e-97b3-63de5fc97b85} that were previously added to the FragmentManager through a separate FragmentTransaction.
at androidx.fragment.app.FragmentManager.saveBackStackState(FragmentManager.java:2450)
at androidx.fragment.app.FragmentManager$SaveBackStackState.generateOps(FragmentManager.java:3776)
at androidx.fragment.app.FragmentManager.generateOpsForPendingActions(FragmentManager.java:2332)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1999)
at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:702)

predictiveBackSample.zip

91 KB

Download

Comments

tr...@gmail.com <tr...@gmail.com> #2Aug 10, 2024 07:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7c1e1040023893a1f24d1e044de30732dbe1737e
Author: Ben Weiss <benweiss@google.com>
Date: Fri Sep 13 13:05:23 2019

Introduce navigation-dynamic-features-fragment

Enable navigating to fragments in com.android.dynamic-feature modules.

Also introduces DefaultProgressFragment and AbstractProgressFragment.
These classes provide progress destinations and enable customization of
progress display.

Bug: 132170186
Bug: 140712620
Bug: 142894369

Test: ./gradlew navigation:navigation-dynamic-features-fragment:check

Change-Id: If2eb6905048e35b67bfe6600d9fc85bbe79416c4

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
A navigation/navigation-dynamic-features-fragment/api/2.3.0-alpha01.txt
A navigation/navigation-dynamic-features-fragment/api/current.txt
A navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_2.3.0-alpha01.txt
A navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
A navigation/navigation-dynamic-features-fragment/api/res-2.3.0-alpha01.txt
A navigation/navigation-dynamic-features-fragment/api/restricted_2.3.0-alpha01.txt
A navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
A navigation/navigation-dynamic-features-fragment/build.gradle
A navigation/navigation-dynamic-features-fragment/src/androidTest/AndroidManifest.xml
A navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
A navigation/navigation-dynamic-features-fragment/src/androidTest/res/layout/dynamic_activity_layout.xml
A navigation/navigation-dynamic-features-fragment/src/androidTest/res/navigation/default_progress_navigation.xml
A navigation/navigation-dynamic-features-fragment/src/main/AndroidManifest.xml
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigator.java
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.java
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/AbstractProgressFragment.java
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/DefaultProgressFragment.java
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/InstallViewModel.java
A navigation/navigation-dynamic-features-fragment/src/main/res/layout/dynamic_feature_install_fragment.xml
A navigation/navigation-dynamic-features-fragment/src/main/res/values/attrs.xml
A navigation/navigation-dynamic-features-fragment/src/main/res/values/ids.xml
A navigation/navigation-dynamic-features-fragment/src/main/res/values/strings.xml
M settings.gradle

https://android-review.googlesource.com/1120991

https://goto.google.com/android-sha1/7c1e1040023893a1f24d1e044de30732dbe1737e

fo...@gmail.com <fo...@gmail.com> #3Aug 16, 2024 05:46AM

I believe it's a duplicate of this one: 342419080.

tr...@gmail.com <tr...@gmail.com> #4Aug 16, 2024 06:22AM

Yes, I realize that. Is there a workaround for this other than disabling the predictive back animation?

tr...@gmail.com <tr...@gmail.com> #5Oct 25, 2024 03:29AM

I think this issue maybe closed as duplicate of 342419080. Thank you.

il...@google.com <il...@google.com> Oct 25, 2024 05:16AM

Status: Duplicate of

342419080

Issue 358743378