Status Update
Comments
bl...@google.com <bl...@google.com> #2
I believe --jobs
to x.py
, so RBE's "more parallelism" benefit doesn't really exist as it stands.
On the other hand, passing --jobs=$(get_makeopts_jobs)
applies that limit to both Rust's and LLVM's builds. cargo -j1000
isn't being a good citizen on machines that are also running make -j$(ncpu)
.
Maybe there's room for a local patch, and/or advocating upstream for --llvm-jobs
, depending on whether reclient
can be made to work with the rustc
invocations here.
gb...@google.com <gb...@google.com> #3
Hrmm,
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o
/var/tmp/portage/dev-lang/rust-host-1.75.0-r1/files/reclient_compiler_launcher.sh /usr/bin/x86_64-pc-linux-gnu-clang++ -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/tmp/portage/dev-lang/rust-host-1.75.0-r1/work/build/x86_64-pc-linux-gnu/llvm/build/lib/Demangle -I/var/tmp/portage/dev-lang/rust-host-1.75.0-r1/work/rustc-1.75.0-src/src/llvm-project/llvm/lib/Demangle -I/var/tmp/portage/dev-lang/rust-host-1.75.0-r1/work/build/x86_64-pc-linux-gnu/llvm/build/include -I/var/tmp/portage/dev-lang/rust-host-1.75.0-r1/work/rustc-1.75.0-src/src/llvm-project/llvm/include -ffunction-sections -fdata-sections -fPIC --target=x86_64-pc-linux-gnu -pipe -fprofile-use=/var/tmp/portage/dev-lang/rust-host-1.75.0-r1/work/rust-pgo-1.75.0-llvm.profdata -fvisibility-inlines-hidden -w -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -MF lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o.d -o lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -c /var/tmp/portage/dev-lang/rust-host-1.75.0-r1/work/rustc-1.75.0-src/src/llvm-project/llvm/lib/Demangle/MicrosoftDemangle.cpp
F0306 00:48:52.636827 8376 main.go:174] Command failed: rpc error: code = Internal desc = /mnt/host/source/src/chromium/depot_tools/.cipd_bin/reclient/scandeps_server terminated during startup: %!w(*command.Result=&{127 3 <nil>})
[2/2503] Building CXX object lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangleNodes.cpp.o
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangleNodes.cpp.o
Looks like reclient
didn't like something?
se...@google.com <se...@google.com> #4
Do you have any of the reproxy logs? Looks like it might be a dependency scanner issue.
se...@google.com <se...@google.com> #5
I assume Raul got the those lines from
Other CQ builders passed, but it's unclear to me if those successfully used reclient in this run, since the ebuild_logs
tarball for e.g., rust-host
. I presume this extends to all host packages, which is unfortunate if so. I can add a die
to check though.
ar...@collabora.corp-partner.google.com <ar...@collabora.corp-partner.google.com> #6
Re #5, If you expand the process_remoteexec_artifacts
step in that builder, you can find the reclient logs.
se...@google.com <se...@google.com> #7
I0306 00:47:06.624986 762 depsscannerclient.go:500] Starting service: [/mnt/host/source/src/chromium/depot_tools/.cipd_bin/reclient/scandeps_server --server_address unix:///tmp/depscan-dev-lang_rust-host-1.75.0-r1.sock --cache_dir --deps_cache_max_mb 128 --noenable_deps_cache]
I0306 00:47:06.629764 762 depsscannerclient.go:59] depsscannerclient stdout:
E0306 00:47:06.630006 762 depsscannerclient.go:64] depsscannerclient stderr: /mnt/host/source/src/chromium/depot_tools/.cipd_bin/reclient/scandeps_server: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory
E0306 00:47:06.630509 762 main.go:344] Failed to initialize input processor: /mnt/host/source/src/chromium/depot_tools/.cipd_bin/reclient/scandeps_server terminated during startup: %!w(*command.Result=&{127 3 <nil>})
I0306 00:47:06.630537 762 server.go:218] Startup status: Input Processor started? false, RBE connected (or disabled)? false, Startup error? true
lol, libstd++ strikes again!
ar...@collabora.corp-partner.google.com <ar...@collabora.corp-partner.google.com> #8
Ugh, that means that you will need to add sys-devel/gcc
as BDEPEND to rust-host
:`(
se...@google.com <se...@google.com> #9
Yeah, that's a pretty heavy dependency :/
I'm happy to add it, but it's a bit weird to me that we're pulling these binaries in as prebuilts rather than building from source. CrOS generally defaults to building ~everything from source.
Description
Hi,
tast-lint
relies ongolint
which has been deprecated and frozen upstream. ChromeOS is now usingstaticcheck
as the main Go linter (golint
from the list of supported packages.Tast being the last remaining user of
golint
, please investigate if and how this can be replaced with a modern, maintained alternative.Thanks!
PS: as I don't have access to the most appropriate component, feel free to move/reassign this issue.