Text with TextOverflow.Ellipsis, TextAlign.Center and letter spacing is moving to the right [389707025]

Assigned

Bug

Status Update

No update yet.

Description

po...@gmail.com

created issue #1

Jan 13, 2025 08:49PM

Jetpack Compose version: 1.7.6
Jetpack Compose component used:
- androidx.compose.ui.text.TextStyle
- androidx.compose.ui.text.style.TextAlign
- androidx.compose.ui.text.style.TextOverflow
Android Studio Build: Ladybug Feature Drop 2024.2.2
Kotlin version: 2.1.0
Devices/Android versions reproduced on: Phone Emulator (API 34)
Keyboard (i.e. Gboard, Samsung, etc): AOSP Keyboard

If you have Material text

Text(
    text = "Hello Android!".repeat(5),
    textAlign = TextAlign.Center,
    letterSpacing = 1.sp,
    overflow = TextOverflow.Ellipsis,
    maxLines = 1
)

inside the layout with Modifier.imePadding() applied to it, and trigger the appearance of the soft keyboard, then text starts to move to the right of the screen.

This bug is very similar to this one and is probably related to this code (it was introduced here).

Screenshots and video attached.

Sample project to reproduce the problem (this is the exact place in the code).

TextPaddingBug.png

155 KB

View

Download

TextPaddingBug Demo.mp4

794 KB

Download

NoTextPaddingBug.png

158 KB

View

Download

Comments

se...@google.com <se...@google.com> #2Jan 13, 2025 09:43PM

as a side note: there are some None, Inherit etc in text classes as well

po...@gmail.com <po...@gmail.com> #3Jan 13, 2025 09:53PM

Siyamed should we file separate issues to track other fields that should be renamed to Unspecified for each instance?

se...@google.com <se...@google.com> #4Jan 14, 2025 06:48PM

Drive by. I filed a ticket for TextUnit after the API council meeting: b/169704897

se...@google.com <se...@google.com> #5Jan 14, 2025 09:49PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit cd46cc34028f844feeb03578bc665db4c7394c14
Author: Nader Jawad <njawad@google.com>
Date: Wed Sep 30 19:03:45 2020

Rename Color.Unset to Color.Unspecified

Relnote: "As part of the standardization
of sentinel values for inline classes,
rename Color.Unset to Color.Unspecified
for consistency with other inline classes"

Fixes: 169797763
Test: re-ran compose tests
Change-Id: I9761102e79ade32812984466c020f2715065ac85

M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldCursorTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BaseTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Text.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MenuTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Colors.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleIndication.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Color.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/colorspace/ColorSpaces.kt
M compose/ui/ui-graphics/src/test/java/androidx/compose/ui/graphics/ColorTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/TextPaintExtensions.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraph.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Paragraph.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopParagraph.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SpanStyleTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/inspector/ParameterFactoryTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/inspector/ParameterFactory.kt

https://android-review.googlesource.com/1443616

se...@google.com <se...@google.com> #6Jan 14, 2025 09:49PM

TextStyle(
            textAlign = TextAlign.Center,
            letterSpacing = 1.sp,
            lineHeight = 24.sp,
            lineHeightStyle = LineHeightStyle(
                alignment = LineHeightStyle.Alignment.Center,
                trim = LineHeightStyle.Trim.None,
                mode = LineHeightStyle.Mode.Fixed
            ),
        )

Message last modified on Jan 14, 2025 10:01PM

se...@google.com <se...@google.com> #7Jan 15, 2025 12:40AM

Reassigned to se...@google.com.

Fix coming. Will see if I can get it into 1.8-beta01.

fixed video.webm

510 KB

Download

po...@gmail.com <po...@gmail.com> #8Jan 15, 2025 01:00AM

Amazing! That was super quick)

se...@google.com <se...@google.com> #9Jan 15, 2025 07:23PM

Excellent bug report and I had some idle cycles this week :)

Issue 389707025

Description

Issue summary

Comments

se...@google.com <se...@google.com> #2Jan 13, 2025 09:43PM

po...@gmail.com <po...@gmail.com> #3Jan 13, 2025 09:53PM

se...@google.com <se...@google.com> #4Jan 14, 2025 06:48PM

se...@google.com <se...@google.com> #5Jan 14, 2025 09:49PM

se...@google.com <se...@google.com> #6Jan 14, 2025 09:49PM

se...@google.com <se...@google.com> #7Jan 15, 2025 12:40AM

po...@gmail.com <po...@gmail.com> #8Jan 15, 2025 01:00AM

se...@google.com <se...@google.com> #9Jan 15, 2025 07:23PM

Add comment

Issue metadata