Unable to find common super type for <class_name> and <class_name> [231997058]

Fixed

Bug

Status Update

No update yet.

Description

ro...@sentry.io

created issue #1

May 10, 2022 10:04AM

Using the new Instrumentation API, I noticed that sometimes I have the following messages when the instrumentation transforms run (this is just one example of those):

Unable to find common super type for java/lang/Object and kotlin/coroutines/Continuation.
Unable to find common super type for kotlin/coroutines/Continuation and java/lang/Throwable.
Unable to find common super type for java/lang/reflect/Method and kotlin/Result$Companion.
Unable to find common super type for kotlin/KotlinNullPointerException and kotlin/coroutines/Continuation.

After checking the sources, I found out the warnings are being printed here, which gave me an impression that I cannot actually fix this on my site.

Some background on my instrumentation: I am looking at all classes (so not filtering anything in the isInstrumentable method) and then replacing some method calls with my static instrumented method calls. So I'd need those classes to be gone through the FixFramesClassWriter as well.

If there's nothing I can fix on my site, can this at least be an info or debug level log? It seems it doesn't affect the instrumentation or the runtime behavior of the app, so sounds like this can be avoided to pollute users' console log.

Studio Build: N/A Version of Gradle Plugin: 7.2 Version of Gradle: N/A Version of Java: 11 OS: N/A

Comments

lu...@google.com <lu...@google.com> May 10, 2022 10:05AM

Assigned to an...@google.com.

je...@google.com <je...@google.com> May 10, 2022 03:17PM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #2May 11, 2022 11:25AM

I have not seen any information about it so just asking here to avoid opening another issue. It also seems that when generating APK with alpha 8 the dex is no more compressed in the APK and stored as is. Leading to way bigger APKs.

While this is not an issue when distributing via Play Store, this could have impact for all the other distribution channels. Is this a normal wanted change and we'll have to deal with it? Or is there some new parameter to control this?

ro...@sentry.io <ro...@sentry.io> #3May 11, 2022 03:48PM

I can reproduce the originally reported issue of missing Baseline Profiles with AGP 8.0.0-alpha08. To verify, check out the bw/agp8 branch of the samples, create and inspect release builds.

Message last modified on May 16, 2022 07:15AM

am...@google.com <am...@google.com> #4May 26, 2022 02:15PM

AS for comment#2, I recommend creating a new issue.

ro...@sentry.io <ro...@sentry.io> #5May 30, 2022 08:53AM

Created https://issuetracker.google.com/issues/259832799 can't triage to proper component.

am...@google.com <am...@google.com> #6May 31, 2022 01:25PM

the location of the baseline profile has changed, it is now in dexopt folder instead of com.android.tools.build.profiles

please file a different bug for other issues so we can assign them correctly for each issue.

ro...@sentry.io <ro...@sentry.io> #7Jun 13, 2022 10:09AM

There is no dexopt or any baseline profile related file in the generated aab. There is also nothing related to baseline profile in APK generated with AGP 8.0.

Can you please verify, keep the issue opened and provide a solution?

Message last modified on Jun 13, 2022 10:13AM

ro...@sentry.io <ro...@sentry.io> #8Jun 27, 2022 11:24AM

As a side note I do use:

android.experimental.enableNewResourceShrinker.preciseShrinking=true

And

<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:tools="http://schemas.android.com/tools"
    tools:shrinkMode="strict" />

So maybe depending on when the baseline is packaged it's removed, but in all case it's not working currently so not really WAI.

am...@google.com <am...@google.com> #9Sep 29, 2022 12:41PM

Marked as fixed.

It's not working either for me. And I don't have android.experimental.enableNewResourceShrinker.preciseShrinking=true and tools:shrinkMode='strict'

ro...@sentry.io <ro...@sentry.io> #10Sep 29, 2022 01:01PM

Still happening with AGP 8.0.0-alpha09. Release build apk don't include baseline profile in assets/dexopt/

ke...@gmail.com <ke...@gmail.com> #11Jun 19, 2023 10:30AM

When they quickly close like that without checking on most part of the tracker anything written after is just plain ignored..

Need to reopen an issue, since no access to proper category hope again that triage put it in the proper place then hope that this time it's properly read.

If only all the parts could be like the R8/D8 part of this issue tracker.